Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make dark header configurable #2528

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 15, 2024

Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header.

Requires nextcloud-libraries/nextcloud-vue#6083

@mejo- mejo- added regression Regression of a previous working feature 3. to review Waiting for reviews labels Sep 15, 2024
@mejo- mejo- added this to the Nextcloud 31 milestone Sep 15, 2024
@mejo- mejo- self-assigned this Sep 15, 2024
@mejo- mejo- mentioned this pull request Sep 15, 2024
2 tasks
@mejo-
Copy link
Member Author

mejo- commented Sep 15, 2024

nextcloud/text#6404 contains screenshots of what this fixes.

@mejo- mejo- force-pushed the fix/configurable_header_dark branch from c732f45 to b3a4444 Compare September 15, 2024 15:45
@mejo-
Copy link
Member Author

mejo- commented Sep 15, 2024

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 15, 2024
@mejo- mejo- force-pushed the fix/configurable_header_dark branch 2 times, most recently from 2da2de3 to 2270487 Compare September 17, 2024 14:27
@mejo- mejo- marked this pull request as ready for review September 17, 2024 14:27
@mejo-
Copy link
Member Author

mejo- commented Sep 17, 2024

Ready for review.

@mejo- mejo- force-pushed the fix/configurable_header_dark branch from 2270487 to 57be472 Compare September 17, 2024 14:50
@mejo-
Copy link
Member Author

mejo- commented Sep 17, 2024

@susnux @skjnldsv any idea about the failing cypress test in runner #5? It doesn't look related to me 😢

Required to fix regression with Text in Viewer in Nextcloud 30, where we
still want a white viewer header.

Also fixes the header color for PDFs with light theme.
Fixes: nextcloud/text#6386

Co-authored-by: Jonas <jonas@freesources.org>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@mejo-
Copy link
Member Author

mejo- commented Sep 17, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit a6b56f9 into master Sep 17, 2024
27 of 29 checks passed
@skjnldsv skjnldsv deleted the fix/configurable_header_dark branch September 17, 2024 21:25
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews regression Regression of a previous working feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants