Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headings papercuts #6404

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix headings papercuts #6404

merged 2 commits into from
Sep 16, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 15, 2024

📝 Summary

Quick fixes from design feedback during conference:

  • Remove blue top border in viewer, as it doesn't look nice with open sidebar.
  • Add bottom border line to menubar. Better visual separation of menubar and editor content, especially when scrolling long content.

🖼️ Screenshots

🏚️ Before logged in 🏡 After logged in
image image
🏚️ Before public read-only share 🏡 After public read-only share
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

It doesn't look nice with open sidebar.

Signed-off-by: Jonas <jonas@freesources.org>
Better visual separation of menubar and editor content, especially when
scrolling long content.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added this to the Nextcloud 31 milestone Sep 15, 2024
@mejo- mejo- self-assigned this Sep 15, 2024
@mejo-
Copy link
Member Author

mejo- commented Sep 15, 2024

/backport to stable30

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Thanks for the feedback as well @bentuna!

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Thanks for the feedback as well @bentuna!

@mejo- mejo- merged commit c48d7ff into main Sep 16, 2024
59 of 61 checks passed
@mejo- mejo- deleted the fix/headings_papercuts branch September 16, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants