feat: apply toastmark parser to merged table plugin #1011
Conversation
apps/editor/src/js/pluginHelper.js
Outdated
| ); | ||
| } | ||
|
|
||
| return {}; |
There was a problem hiding this comment.
plugins가 없을때를 먼저 체크하고 빈 객체를 반환해주는 조건을 먼저 처리해주면 if문도 하나 줄고 가독성에도 좋은 것 같아요ㅎ
if (!plugins) {
return {};
}
return plugins.reduce( /* */ );
| @@ -0,0 +1,81 @@ | |||
| function extractPropertiesForMerge(value, type, oppossitType) { | |||
There was a problem hiding this comment.
oppossitType -> oppositeType 이용ㅎ
| @@ -0,0 +1,81 @@ | |||
| function extractPropertiesForMerge(value, type, oppossitType) { | |||
There was a problem hiding this comment.
근데 oppositeType에는 어떤 값이 들어오나요??
퍼블릭 함수는 아니지만 type이나 oppositeType 값에 대한 주석이 있으면 좋겠습니다.
(이럴때 타입이 없으니 불편하군요 ㅜㅜ)
There was a problem hiding this comment.
기존 함수 주석 살려 놓을게요~!
/**
* Extract properties for merge.
* @param {string} value - value
* @param {string} type - merge type like colspan, rowspan
* @param {string} oppositeType - opposite merge type
* if merge type is colspan, opposite merge type is rowspan
* @returns {Array.<number|string>} - returns merge count and value
* @private
*/
|
|
||
| function parserTableCellWithRowspanMap(node, parent, rowspan) { | ||
| const prevRow = parent.prev; | ||
| const columnLen = parent.parent.parent.columns.length; |
There was a problem hiding this comment.
parent 값이 이 값들과 맞나요? parent.parent 값 유무를 체크할 필요는 없을지 궁금해서 질문해봅니다ㅎ
parent = `tableRow`
parent.parent = `tableBody`
parent.parent.parent = `table`
There was a problem hiding this comment.
아래 같은 경우도 있고 나머지는 말씀하신대로 입니다! 파싱로직 내에서 parent.parent는 null 인 경우가 없어 별도 체크는 하지 않아도 될 것 같습니다.
parent.parent = `tableHead`
| * @fileoverview Test merged table parser | ||
| * @author NHN FE Development Lab <dl_javascript@nhn.com> | ||
| */ | ||
| import { source } from 'common-tags'; |
There was a problem hiding this comment.
에디터 적용하는 피처에 있었는데ㅋㅋㅋ 역시 빠르시군요 👍
| ]; | ||
|
|
||
| examples.forEach(({ no, content, result }) => { | ||
| it(`example1${no}`, () => { |
There was a problem hiding this comment.
example1${no} -> example${no} 요렇게 되어야하지 않을까요ㅎ
|
이렇게 데이터가 들어간 경우에 테이블이 깨지는데 확인 부탁드릴게요~ | @cols=2:merged |
| --- | --- |
| table | table |
|
| if (entering) { | ||
| inEmph = true; | ||
| } else { | ||
| inEmph = false; | ||
| } |
There was a problem hiding this comment.
테스트 코드라 크게 문제되는건 아니지만.. 이렇게 처리할수도 있겠네요ㅎ
inEmph = entering;There was a problem hiding this comment.
commonmark 예제를 그대로 가져오다보니 그렇네요. 수정하겠습니다ㅎㅎ
|
js87zz
force-pushed
the
feat/merged-table-with-toastmark
branch
from
e7dff24 to
e7b2374
Compare
* feat: chart extension * feat: multiple chart instance * refactor: csv, dsv parser to papa * refactor: apply review (ref #1010) * fix: remove papa global dependency (fix #1011) * refactor: change default chart to column * feat: support whitespace separated values for chart data (ref #1009) * refactor: apply code review (ref #1013)
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨