Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the editing performance with list which has long depth(fix #1012) #1013

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Jun 2, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

related issue(#1012)


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz changed the title fix: improve the editing performance with list which has long depth(fix: #1012) fix: improve the editing performance with list which has long depth(fix #1012) Jun 2, 2020
@js87zz js87zz requested a review from seonim-ryu June 3, 2020 06:30
Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[6/3] 간단하네요ㅎ 👍

@js87zz js87zz merged commit a2f95ae into master Jun 8, 2020
@js87zz js87zz deleted the fix/editing-performance branch June 8, 2020 02:09
@seonim-ryu seonim-ryu added this to the 2.2.0 milestone Jun 11, 2020
js87zz pushed a commit that referenced this pull request Jun 17, 2021
* feat: chart extension

* feat: multiple chart instance

* refactor: csv, dsv parser to papa

* refactor: apply review (ref #1010)

* fix: remove papa global dependency (fix #1011)

* refactor: change default chart to column

* feat: support whitespace separated values for chart data (ref #1009)

* refactor: apply code review (ref #1013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants