Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table's contextmenu oveflows in certain languages (fix #891) #1016

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Jun 2, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Preview

  • Default style
    default

  • Specific languages
    ru


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu requested review from js87zz and shiren and removed request for shiren June 2, 2020 09:08
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료입니다~!

@@ -582,6 +583,7 @@
}

.te-popup-table-utils hr {
margin: 0;
Copy link
Member Author

@seonim-ryu seonim-ryu Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨텍스트 메뉴 사이에 여백이 발생하는 현상이 있어서 수정함

hr

@seonim-ryu seonim-ryu merged commit 964009c into master Jun 4, 2020
@seonim-ryu seonim-ryu deleted the fix/overflow-table-contextmenu branch June 8, 2020 02:41
@seonim-ryu seonim-ryu added this to the 2.2.0 milestone Jun 11, 2020
js87zz pushed a commit that referenced this pull request Jun 17, 2021
* feat: chart extension

* feat: multiple chart instance

* refactor: csv, dsv parser to papa

* refactor: apply review (ref #1010)

* fix: remove papa global dependency (fix #1011)

* refactor: change default chart to column

* feat: support whitespace separated values for chart data (ref #1009)

* refactor: apply code review (ref #1013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants