Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support templates other than MNI152NLin2009cAsym #1558

Closed
oesteban opened this issue Mar 27, 2019 · 9 comments · Fixed by #1596
Closed

Support templates other than MNI152NLin2009cAsym #1558

oesteban opened this issue Mar 27, 2019 · 9 comments · Fixed by #1596
Assignees
Labels
effort: low Estimated low effort task impact: high Estimated high impact task

Comments

@oesteban
Copy link
Member

Now that TemplateFlow is up and seemingly running okay, it is time to open up the --template option and allow additional template keywords.

This is related to nipreps/smriprep#50 where the CLI interface will be reconsidered and where we will come up with a solution for people who want to run normalization to two or more templates.

@oesteban oesteban added impact: high Estimated high impact task effort: low Estimated low effort task labels Mar 27, 2019
@oesteban
Copy link
Member Author

cc @satra

@satra
Copy link

satra commented Mar 29, 2019

more than other templates, i think i would want to extract individual space data. that being said, custom/other templates would likely be helpful to extend fmriprep to other workflows (e.g., infant mri)

@oesteban
Copy link
Member Author

Absolutely. I pinged you because now fsLR can be applied as the target and generating HCP-compliant CIfTIs will be much easier - at least for the volumetric part.

@oesteban oesteban self-assigned this Mar 30, 2019
@satra
Copy link

satra commented Mar 30, 2019

this describes the surface mappings. so if the templates are in place, creating the workflows is not that complicated.

https://wiki.humanconnectome.org/download/attachments/63078513/Resampling-FreeSurfer-HCP.pdf?version=1&modificationDate=1472225460934&api=v2&download=true

@oesteban
Copy link
Member Author

oesteban commented Apr 5, 2019

Necessary surfaces were already there (L, R).

Although discouraged (the recommendation is to align the individual's surfaces to fsLR's via MSM), the files I included into the fsLR template are intented to implement route C of the document.

For the recommended way (or at least more accurate procedures involving surface native spaces), people should use ciftify (wdyt @edickie?).

@edickie
Copy link

edickie commented Apr 5, 2019

Seems like the best plan for the time being. Sorry I haven't had time to contribute to this lately. I'm pretty swamped till May.

@edickie
Copy link

edickie commented Apr 6, 2019

Wait aren't you doing route D in the doc?

@satra
Copy link

satra commented Apr 6, 2019

if fsLR is the target, shouldn't we be going route B (individual to fsLR)?

obviously we will not be able to do single step interpolation, but at least in two steps going from bold to individual surface and then to fsLR

@oesteban
Copy link
Member Author

oesteban commented Apr 17, 2019

I'll be using the fs_LR-deformed_to-fsaverage.?.sphere.???k_fs_LR.surf.gii files, just for convenience. Then, I'll concatenate all the inverse transforms from BOLD to fsaverage and map all coordinates from fsaverage to BOLD and sample via interpolation. Basically, I'll resample into fsaverage with just 1 step.

EDIT: that is kind of option A of the document, but skipping the fsaverage-to-fsLR step with the workbench.

oesteban added a commit to oesteban/smriprep that referenced this issue Apr 20, 2019
A new spatial normalization workflow has been outsourced from the main
anatomical workflow - closes nipreps#1.

This addition is crucial for the implementation of
nipreps/fmriprep#1558 and more generally, nipreps/fmriprep#1588.
oesteban added a commit to oesteban/niworkflows that referenced this issue Apr 23, 2019
…ataSink``

Permit setting a list of ``allowed_entities`` at the instantiation time
of ``DerivativesDataSink``s so that it is possible to create arbitrary,
dynamic BIDS entities for the output file name without confusion with dynamic
metadata keys.

The reason to add this feature is to allow a more flexible interface for
derivatives generated via iterables in the context of
nipreps/fmriprep#1558.
oesteban added a commit to oesteban/niworkflows that referenced this issue Apr 23, 2019
This refactor is necessary in the context of nipreps/fmriprep#1558
in order to allow a more flexible generation of reports.

The report factory now depends on a BIDSLayout, with a new configuration
file (by default, this is ``niworkflows/viz/figures.json``)

Ordering of tasks, runs, etc happens at query time.

The general structure of the reports is still handled by a
``config.json`` object, in which the BIDS entities to be queried are
listed (replacing the former regex patterns).

The overal Jinja template and the config file now look a bit cleaner
with several simplifications.
oesteban added a commit to oesteban/fmriprep that referenced this issue Apr 30, 2019
This is a large refactor using two major inter-related features:
  - Uses nipreps/smriprep#72 and its continuation within
    nipreps/smriprep#75 to permit the specification of several
    spatial normalization targets (close nipreps#1558).
  - Uses the refactor of Reports generation of
    nipreps/niworkflows#344, which enables rendering reports with
    several normalization spaces. Correspondingly, report generation
    code and config files have been removed.

Correspondingly, the new interface for ``--output-spaces`` is also
incorporated (close nipreps#1588).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Estimated low effort task impact: high Estimated high impact task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants