-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Allow multiple {non,}standard spaces (--output-spaces
)
#1596
Conversation
This is a large refactor using two major inter-related features: - Uses nipreps/smriprep#72 and its continuation within nipreps/smriprep#75 to permit the specification of several spatial normalization targets (close nipreps#1558). - Uses the refactor of Reports generation of nipreps/niworkflows#344, which enables rendering reports with several normalization spaces. Correspondingly, report generation code and config files have been removed. Correspondingly, the new interface for ``--output-spaces`` is also incorporated (close nipreps#1588).
This is working seemingly fine with ds005 locally, including I expect many issues building docs and running ds054 though. |
c7b57de
to
416610f
Compare
If you want a review before the CI is fixed, let me know. |
Let's wait for Circle to be all green 👍 |
Okay, this is looking much better. Last commit is a good candidate for getting all green lights. Documentation is not failing anymore and it looks fine: https://3557-53608443-gh.circle-artifacts.com/0/home/circleci/out/docs/usage.html#defining-standard-and-nonstandard-spaces-where-data-will-be-resampled EDIT: ds054 is passing |
Ref. ds210, it seems the reports generator has been confused with the echos since forever. In principle, there's only one run in our test version of ds210. (opened #1598) |
I can check and see if things have been updated, but it should be showing only one "echo" because that image is actually the optimal combination. We implemented that as the default in the last big ME PR ! |
I think that big PR is working alright, my suspicion is that this is a little bug of the reports generator. |
Leave for a future PR the implementation of HCP-compatible cifti. Also, run a ``KeySelect`` to extract the appropriate BOLD in standard space resampling.
Otherwise, it is not guaranteed that the last commit will be picked.
…clude MNI152NLin6Asym derivatives
@effigies this is finally ready for you |
Co-Authored-By: oesteban <code@oscaresteban.es>
5ba13a6
to
695dd03
Compare
b1c9f33
to
4afb89b
Compare
DOC: Companion of #1596 + punctual improvements of docs
This is a large refactor using two major inter-related features:
ENH: Support for multiple
--output-spaces
smriprep#75 to permit the specification of severalspatial normalization targets (close Support templates other than MNI152NLin2009cAsym #1558).
ENH: Refactor of the Report generation tools niworkflows#344, which enables rendering reports with
several normalization spaces. Correspondingly, report generation
code and config files have been removed.
Correspondingly, the new interface for
--output-spaces
is alsoincorporated (close #1588).