Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sdk additional functions #73

Merged
merged 16 commits into from
Mar 19, 2024
Merged

Feature/sdk additional functions #73

merged 16 commits into from
Mar 19, 2024

Conversation

Jarek-Rolski
Copy link
Contributor

I added several functions to rAPId SDK and created relevant test function:

  1. create_user
  2. delete_user
  3. list_subjects
  4. list_layers
  5. list_protected_domains
  6. delete_dataset

I compiled and tested sdk package locally. I didn't find any issues.

@Jarek-Rolski Jarek-Rolski changed the base branch from release/v7.0.9-v0.1.7 to main January 29, 2024 10:21
MotwaniM
MotwaniM requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@MotwaniM MotwaniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks pretty good, thank you for contributing! I've made some comments, happy to chat through them on a call.

sdk/rapid/rapid.py Show resolved Hide resolved
sdk/rapid/rapid.py Show resolved Hide resolved
sdk/tests/test_rapid.py Show resolved Hide resolved
sdk/tests/test_rapid.py Show resolved Hide resolved
sdk/tests/test_rapid.py Outdated Show resolved Hide resolved
sdk/tests/test_rapid.py Outdated Show resolved Hide resolved
@Jarek-Rolski
Copy link
Contributor Author

Jarek-Rolski commented Feb 9, 2024 •
edited
Loading

Now functions I added handle all errors I was able to notice. However, there are some issues with errors/codes returned by API.
in remove_dataset - function returns status code 202 when dataset doesn't exists, but layer is correct
in create_user - function returns status code 400 for two types of error

@Jarek-Rolski Jarek-Rolski requested a review from MotwaniM February 9, 2024 14:20
@MotwaniM MotwaniM added the sdk Part of the sdk label Feb 16, 2024
@MotwaniM MotwaniM changed the base branch from main to release/v7.0.10-v0.1.8 February 16, 2024 11:49
@TobyDrane TobyDrane merged commit 4d5288f into no10ds:release/v7.0.10-v0.1.8 Mar 19, 2024
TobyDrane added a commit that referenced this pull request Mar 21, 2024
@TobyDrane @Jarek-Rolski @MotwaniM
Release: API v7.10.0 SDK v0.1.8 (#84)
d8a8e90 
* Fix issues with links not working within read the docs (#83)

* Feature/sdk additional functions (#73)

* user create/delete

* add functions

* add tests

* fix sdk test functions bug

* fix test function url bug

* cover user create and dataset delete errors raise

* fix errors handling and testing

* fix syntax bug

* fix error with mocked responses

* standarize functions when undefined error code

* fix test mock response

* Extra Output Blocks (#80)

* output blocks

* respond to comments

* fix ckan_sg issue (#79)

* Changelog

---------

Co-authored-by: Jarek-Rolski <89912297+Jarek-Rolski@users.noreply.github.com>
Co-authored-by: MotwaniM <73472421+MotwaniM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MotwaniM MotwaniM MotwaniM approved these changes

Assignees
No one assigned
Labels
sdk Part of the sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jarek-Rolski @MotwaniM @TobyDrane