Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Output Blocks #80

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

MotwaniM
Copy link
Contributor

Output blocks to remove hardcoded values from ckan_deployment

@MotwaniM MotwaniM marked this pull request as ready for review February 20, 2024 12:29
@MotwaniM MotwaniM requested a review from TobyDrane February 20, 2024 12:29
@MotwaniM MotwaniM changed the base branch from main to release/v7.0.10-v0.1.8 February 20, 2024 12:29
@TobyDrane TobyDrane changed the title output blocks Extra Output Blocks Feb 20, 2024
Copy link
Contributor

@TobyDrane TobyDrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MotwaniM For these outputs you will also need to output them from the blocks and also the rapid module aswell

infrastructure/modules/app-cluster/outputs.tf Outdated Show resolved Hide resolved
@MotwaniM MotwaniM requested a review from TobyDrane February 20, 2024 17:11
@TobyDrane TobyDrane merged commit 07d9955 into release/v7.0.10-v0.1.8 Mar 19, 2024
6 checks passed
@TobyDrane TobyDrane deleted the feature/tf_ckan_outputs branch March 19, 2024 16:42
TobyDrane added a commit that referenced this pull request Mar 21, 2024
* Fix issues with links not working within read the docs (#83)

* Feature/sdk additional functions (#73)

* user create/delete

* add functions

* add tests

* fix sdk test functions bug

* fix test function url bug

* cover user create and dataset delete errors raise

* fix errors handling and testing

* fix syntax bug

* fix error with mocked responses

* standarize functions when undefined error code

* fix test mock response

* Extra Output Blocks (#80)

* output blocks

* respond to comments

* fix ckan_sg issue (#79)

* Changelog

---------

Co-authored-by: Jarek-Rolski <89912297+Jarek-Rolski@users.noreply.github.com>
Co-authored-by: MotwaniM <73472421+MotwaniM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants