Remove Inline LB Security Group Rules #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobyDrane
approved these changes
Feb 20, 2024
TobyDrane
added a commit
that referenced
this pull request
Mar 21, 2024
* Fix issues with links not working within read the docs (#83) * Feature/sdk additional functions (#73) * user create/delete * add functions * add tests * fix sdk test functions bug * fix test function url bug * cover user create and dataset delete errors raise * fix errors handling and testing * fix syntax bug * fix error with mocked responses * standarize functions when undefined error code * fix test mock response * Extra Output Blocks (#80) * output blocks * respond to comments * fix ckan_sg issue (#79) * Changelog --------- Co-authored-by: Jarek-Rolski <89912297+Jarek-Rolski@users.noreply.github.com> Co-authored-by: MotwaniM <73472421+MotwaniM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to remove inline security group rules for rapid lb sg. As in the banner note here : https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule sgs with inline rules, and rule resources defined separately, can cause issues such as conflicts and overwrites. Will submit a PR in the CKAN repo as well.