Windows build failure

[targos]

CI run: https://ci.nodejs.org/job/node-compile-windows/17787/label=win-vs2017/console

Error:

[c:\workspace\node-compile-windows\deps\v8\gypfiles\torque.vcxproj]
  XPath.cpp
  tztrans.cpp
  XPathElement.cpp
  ucal.cpp
  ucln_in.cpp
  ucol.cpp
  XPathLexer.cpp
  XPathLexerErrorListener.cpp
  ucoleitr.cpp
  ucol_res.cpp
  ucol_sit.cpp
  XPathRuleAnywhereElement.cpp
  ucsdet.cpp
..\third_party\antlr4\runtime\Cpp\runtime\src\tree\pattern\ParseTreePatternMatcher.cpp(105): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc [c:\workspace\node-compile-windows\deps\v8\gypfiles\torque.vcxproj]
  udat.cpp
  udateintervalformat.cpp
..\third_party\antlr4\runtime\Cpp\runtime\src\tree\pattern\ParseTreePatternMatcher.cpp(113): error C2280: 'void std::rethrow_if_nested<antlr4::ParseCancellationException>(const _Ty &)': attempting to reference a deleted function [c:\workspace\node-compile-windows\deps\v8\gypfiles\torque.vcxproj]
          with
          [
              _Ty=antlr4::ParseCancellationException
          ]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\exception(464): note: see declaration of 'std::rethrow_if_nested'

/cc @nodejs/platform-windows

[refack]

I'm going to go ahead and cherry-pick this (with the aix fix) into the canary-base branch. We can investigate the Windows issue separately. It doesn't have to block all canary builds.

I'll look into this. But if anyone else has a quick solution, please go ahead.

[seishun]

This happens because node disables run-time type information: https://github.com/nodejs/node-v8/blob/canary/common.gypi#L206 The commit message doesn't explain why: nodejs/node@2e2df04 cc @piscisaureus

But if I remove that line (or just build a Debug build), I get a bunch of unresolved externals:

     Creating library C:\Users\Nikolai\node\Release\torque.lib and object C:\Users\Nikolai\node\Release\torque.exp
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::CheckMemoryP
ressure(void)" (?CheckMemoryPressure@Isolate@v8@@AEAAXXZ) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::ReportExtern
alAllocationLimitReached(void)" (?ReportExternalAllocationLimitReached@Isolate@v8@@AEAAXXZ) [C:\Users\Nikolai\node\deps
\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: class v8::Local<class v8::Context> __cd
ecl v8::Isolate::GetCurrentContext(void)" (?GetCurrentContext@Isolate@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) [C:\Users\
Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Exit(void)" (
?Exit@Isolate@v8@@QEAAXXZ) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Enter(void)"
(?Enter@Isolate@v8@@QEAAXXZ) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: static class v8::Isolate * __cdecl v8::
Isolate::GetCurrent(void)" (?GetCurrent@Isolate@v8@@SAPEAV12@XZ) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj
]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ScriptCompiler
::ExternalSourceStream::ResetToBookmark(void)" (?ResetToBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAAXXZ) [C:\U
sers\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl v8::ScriptCompiler
::ExternalSourceStream::SetBookmark(void)" (?SetBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAA_NXZ) [C:\Users\Ni
kolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::SnapshotCreator::SnapshotCr
eator(__int64 const *,class v8::StartupData *)" (??0SnapshotCreator@v8@@QEAA@PEB_JPEAVStartupData@1@@Z) [C:\Users\Nikol
ai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: static class v8::internal::Object * *
__cdecl v8::HandleScope::CreateHandle(class v8::internal::HeapObject *,class v8::internal::Object *)" (?CreateHandle@Ha
ndleScope@v8@@CAPEAPEAVObject@internal@2@PEAVHeapObject@42@PEAV342@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.v
cxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::HandleScope::~HandleScope(v
oid)" (??1HandleScope@v8@@QEAA@XZ) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Template::Set(class v8
::Local<class v8::Name>,class v8::Local<class v8::Data>,enum v8::PropertyAttribute)" (?Set@Template@v8@@QEAAXV?$Local@V
Name@v8@@@2@V?$Local@VData@v8@@@2@W4PropertyAttribute@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Locker::Initialize(cl
ass v8::Isolate *)" (?Initialize@Locker@v8@@AEAAXPEAVIsolate@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxpr
oj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Unlocker::Initialize(
class v8::Isolate *)" (?Initialize@Unlocker@v8@@AEAAXPEAVIsolate@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.v
cxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::ToLocalEmp
ty(void)" (?ToLocalEmpty@V8@v8@@CAXXZ) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::DisposeGlo
bal(class v8::internal::Object * *)" (?DisposeGlobal@V8@v8@@CAXPEAPEAVObject@internal@2@@Z) [C:\Users\Nikolai\node\deps
\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: static class v8::internal::Object * *
__cdecl v8::V8::CopyPersistent(class v8::internal::Object * *)" (?CopyPersistent@V8@v8@@CAPEAPEAVObject@internal@2@PEAP
EAV342@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Integer>
 __cdecl v8::Value::ToInteger(class v8::Local<class v8::Context>)const " (?ToInteger@Value@v8@@QEBA?AV?$MaybeLocal@VInt
eger@v8@@@2@V?$Local@VContext@v8@@@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object>
__cdecl v8::Value::ToObject(class v8::Local<class v8::Context>)const " (?ToObject@Value@v8@@QEBA?AV?$MaybeLocal@VObject
@v8@@@2@V?$Local@VContext@v8@@@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::String>
__cdecl v8::Value::ToString(class v8::Local<class v8::Context>)const " (?ToString@Value@v8@@QEBA?AV?$MaybeLocal@VString
@v8@@@2@V?$Local@VContext@v8@@@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Boolean>
 __cdecl v8::Value::ToBoolean(class v8::Local<class v8::Context>)const " (?ToBoolean@Value@v8@@QEBA?AV?$MaybeLocal@VBoo
lean@v8@@@2@V?$Local@VContext@v8@@@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::
SharedArrayBuffer> __cdecl v8::ValueDeserializer::Delegate::GetSharedArrayBufferFromId(class v8::Isolate *,unsigned int
)" (?GetSharedArrayBufferFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VSharedArrayBuffer@v8@@@3@PEAVIsolat
e@3@I@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::
WasmCompiledModule> __cdecl v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)" (?G
etWasmModuleFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VWasmCompiledModule@v8@@@3@PEAVIsolate@3@I@Z) [C:
\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::
Object> __cdecl v8::ValueDeserializer::Delegate::ReadHostObject(class v8::Isolate *)" (?ReadHostObject@Delegate@ValueDe
serializer@v8@@UEAA?AV?$MaybeLocal@VObject@v8@@@3@PEAVIsolate@3@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxp
roj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: static class v8::MaybeLocal<class v8::S
tring> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)" (?NewFromUtf8@Stri
ng@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z) [C:\Users\Nikolai\node\deps\v8\gypfile
s\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: void * __cdecl v8::Object::SlowGetAlig
nedPointerFromInternalField(int)" (?SlowGetAlignedPointerFromInternalField@Object@v8@@AEAAPEAXH@Z) [C:\Users\Nikolai\no
de\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "private: class v8::Local<class v8::Value> __cde
cl v8::Object::SlowGetInternalField(int)" (?SlowGetInternalField@Object@v8@@AEAA?AV?$Local@VValue@v8@@@2@H@Z) [C:\Users
\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: class v8::Local<class v8::Context> __cd
ecl v8::Object::CreationContext(void)" (?CreationContext@Object@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) [C:\Users\Nikola
i\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: int __cdecl v8::Object::InternalFieldCo
unt(void)" (?InternalFieldCount@Object@v8@@QEAAHXZ) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ValueSerialize
r::Delegate::FreeBufferMemory(void *)" (?FreeBufferMemory@Delegate@ValueSerializer@v8@@UEAAXPEAX@Z) [C:\Users\Nikolai\n
ode\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual void * __cdecl v8::ValueSeriali
zer::Delegate::ReallocateBufferMemory(void *,unsigned __int64,unsigned __int64 *)" (?ReallocateBufferMemory@Delegate@Va
lueSerializer@v8@@UEAAPEAXPEAX_KPEA_K@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> _
_cdecl v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local<class v8::WasmCompile
dModule>)" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VWasmCompil
edModule@v8@@@3@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> _
_cdecl v8::ValueSerializer::Delegate::GetSharedArrayBufferId(class v8::Isolate *,class v8::Local<class v8::SharedArrayB
uffer>)" (?GetSharedArrayBufferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VSharedArrayBu
ffer@v8@@@3@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<bool> __cdecl v
8::ValueSerializer::Delegate::WriteHostObject(class v8::Isolate *,class v8::Local<class v8::Object>)" (?WriteHostObject
@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@_N@3@PEAVIsolate@3@V?$Local@VObject@v8@@@3@@Z) [C:\Users\Nikolai\node\deps
\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object>
__cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>,int,class v8::Local<class v8::Value> * const)const
 " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@HQEAV?$Local@VValue@v8@@@2@@Z
) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
implementation-visitor.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ObjectTemplate::SetHan
dler(struct v8::IndexedPropertyHandlerConfiguration const &)" (?SetHandler@ObjectTemplate@v8@@QEAAXAEBUIndexedPropertyH
andlerConfiguration@2@@Z) [C:\Users\Nikolai\node\deps\v8\gypfiles\torque.vcxproj]
C:\Users\Nikolai\node\Release\torque.exe : fatal error LNK1120: 36 unresolved externals [C:\Users\Nikolai\node\deps\v8\
gypfiles\torque.vcxproj]

Perhaps we should just build V8 with GN on Windows?

[refack]

I have a lead to a solution... 🤞

[targos]

#58 should fix this

[refack]

#61 might be simpler than 58 (since it doesn't require upstreaming)

[targos]

Fixed in #61