Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] backport d48bd16 from v8 master #22909

Closed
wants to merge 44 commits into from

Commits on Sep 12, 2018

  1. win,msi: install tools for native modules

    Add a dialog during installation with information about native
    modules that can optionally run a Boxstarter script at the end of the
    installation. This script can also be run from Start menu.
    
    Fixes: nodejs#22311
    PR-URL: nodejs#22645
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    joaocgreis authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1c3f81d View commit details
    Browse the repository at this point in the history
  2. doc: node debugnode inspect in CLI docs

    PR-URL: nodejs#22774
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
    addaleax authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    05ace78 View commit details
    Browse the repository at this point in the history
  3. tools: fix doc tool behavior for version arrays

    Even though the doc tool supports version arrays in theory, it fails to
    sort them properly causing the tool to crash.
    
    PR-URL: nodejs#22766
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    94e67b6 View commit details
    Browse the repository at this point in the history
  4. fs: implement mkdir recursive (mkdirp)

    Implements mkdirp functionality in node_file.cc. The Benefit
    of implementing in C++ layer is that the logic is more easily
    shared between the Promise and callback implementation and
    there are notable performance improvements.
    
    This commit is part of the Tooling Group Initiative.
    
    Refs: nodejs/user-feedback#70
    
    PR-URL: nodejs#21875
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Sam Ruby <rubys@intertwingly.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Benjamin Coe authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    779e072 View commit details
    Browse the repository at this point in the history
  5. test: add comment describing test-fs-mkdir

    PR-URL: nodejs#22424
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Jennifer Bland authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    b1be08f View commit details
    Browse the repository at this point in the history
  6. url: provide pathToFileURL and fileURLToPath

    PR-URL: nodejs#22506
    Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    guybedford authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    75c288e View commit details
    Browse the repository at this point in the history
  7. test: check parameter type of fs.mkdir()

    Added tests to check parameter type of fs.mkdir(), fs.mkdirSync()
    and fsPromises.mkdir() to increase coverage.
    
    PR-URL: nodejs#22616
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
    Masashi Hirano authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    42e6ce2 View commit details
    Browse the repository at this point in the history
  8. test: refactor structure of common/index

    PR-URL: nodejs#22511
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    jasnell authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    cf61a04 View commit details
    Browse the repository at this point in the history
  9. assert: align argument names

    This makes sure the documented argument names and the ones thrown
    in errors is aligned with the actual argument name.
    
    PR-URL: nodejs#22760
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    BridgeAR authored and targos committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    108a169 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. doc: add history for withFileTypes in fs.readdir[Sync]()

    PR-URL: nodejs#22794
    Fixes: nodejs#22777
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tiendq authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    09ae073 View commit details
    Browse the repository at this point in the history
  2. crypto: fix public key encryption internals

    Coincidentally, the old version works as well since the padding
    parameter is never null, but it is semantically incorrect.
    
    PR-URL: nodejs#22780
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    8b6a161 View commit details
    Browse the repository at this point in the history
  3. crypto: rename symbols to match guidelines

    PR-URL: nodejs#22770
    Refs: nodejs#22684
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    b87ab0f View commit details
    Browse the repository at this point in the history
  4. doc: add gabrielschulhof to TSC

    PR-URL: nodejs#22818
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Trott authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    b9fd99e View commit details
    Browse the repository at this point in the history
  5. n-api: add generic finalizer callback

    Add `napi_add_finalizer()`, which provides the ability to attach data
    to an arbitrary object and be notified when that object is garbage-
    collected so as to have an opportunity to delete the data previously
    attached.
    
    This differs from `napi_wrap()` in that it does not use up the private
    slot on the object, and is therefore neither removable, nor retrievable
    after the call to `napi_add_finalizer()`. It is assumed that the data
    is accessible by other means, yet it must be tied to the lifetime of
    the object. This is the case for data passed to a dynamically created
    function which is itself heap-allocated and must therefore be freed
    along with the function.
    
    Fixes: nodejs/abi-stable-node#313
    PR-URL: nodejs#22244
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    8153c10 View commit details
    Browse the repository at this point in the history
  6. test: checks on napi factory wrap’s finalization

    Fixes: nodejs#22396
    PR-URL: nodejs#22612
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    legendecas authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    2b3b205 View commit details
    Browse the repository at this point in the history
  7. lib: remove unnecessary symbols

    Remove `(...)`, because this is a simple,sensitive expression.
    
    PR-URL: nodejs#22455
    Reviewed-By: Weijia Wang <starkwang@126.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MaleDong authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    f41911f View commit details
    Browse the repository at this point in the history
  8. test: minor refactor in common/index.js

    PR-URL: nodejs#22738
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
    jasnell authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    01a5c7d View commit details
    Browse the repository at this point in the history
  9. doc: document http2 timeouts

    New default timeout values of "2 minutes" were added into documentation
    inside 2 classes under "Event: 'timeout'":
    1) Class: Http2SecureServer
    2) Class: Http2Server
    
    New sections for `.setTimeout()` method were added inside
    `Http2SecureServer` & `Http2Server` docs.
    
    PR-URL: nodejs#22798
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sagitsofan authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    353cb4e View commit details
    Browse the repository at this point in the history
  10. doc: add reference to guide for N-API additions

    Add reference to guide with requirements/principles
    for accepting additions to N-API.
    
    PR-URL: nodejs#22593
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    a214769 View commit details
    Browse the repository at this point in the history
  11. deps: cherry-pick 2363cdf from upstream V8

    Original commit message:
    
        [tracing] do not add traces when disabled
    
        nodejs#21038
    
        Change-Id: Ic4c9f403b5e54a97d3170b2311dd5aab8c8357c8
        Reviewed-on: https://chromium-review.googlesource.com/1217726
        Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Cr-Commit-Position: refs/heads/master@{nodejs#55809}
    
    Refs: v8/v8@2363cdf
    PR-URL: nodejs#22812
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    ofrobots authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    e85c814 View commit details
    Browse the repository at this point in the history
  12. trace_events: avoid flusing uninitialized traces

    PR-URL: nodejs#22812
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    ofrobots authored and targos committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    92b695e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2018

  1. fs: ensure readdir() callback is only called once

    This commit ensures that the readdir() callback can only be
    called once when the withFileTypes parameter is supplied.
    
    PR-URL: nodejs#22793
    Fixes: nodejs#22778
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    cjihrig authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    4159000 View commit details
    Browse the repository at this point in the history
  2. lib: simplify 'processChunkSync'

    According to the real logic codes, it seems no matter whether 'nread >=
    kMaxLength' or not. We always close the 'self' stream first. So we can
    shorten it by merging them into one sample.
    
    PR-URL: nodejs#22802
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Weijia Wang <starkwang@126.com>
    MaleDong authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    d853a3f View commit details
    Browse the repository at this point in the history
  3. module: add createRequireFunction method

    PR-URL: nodejs#19360
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
    devsnek authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    535c30c View commit details
    Browse the repository at this point in the history
  4. worker: correct (de)initialization order

    - Initialize `thread_exit_async_` only once the thread has been
      started. This is done since it is only triggered from the
      thread when it is exiting.
    - Move the final `uv_run` to the `Worker` destructor.
      This makes sure that it is always run, regardless of whether
      the thread is actually started or not.
    - Always dispose the `Isolate` before cleaning up the libuv event
      loop. This now matches the reverse order of initialization.
    
    Fixes: nodejs#22736
    PR-URL: nodejs#22773
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    ec6afb9 View commit details
    Browse the repository at this point in the history
  5. tools: implement update-authors in JS

    Replace the previous Perl script with a Node.js variant
    that explicitly supports `Author:` and, in particular,
    GitHub’s standard `Co-authored-by:` metadata tags.
    
    PR-URL: nodejs#22771
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    c9f2283 View commit details
    Browse the repository at this point in the history
  6. doc: update AUTHORS list

    This includes some re-ordering due to the newly added
    support for co-authored commits.
    
    PR-URL: nodejs#22771
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    c898071 View commit details
    Browse the repository at this point in the history
  7. src: move getActiveResources/Handles to node_process.cc

    PR-URL: nodejs#22758
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    jasnell authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    878d616 View commit details
    Browse the repository at this point in the history
  8. src: move DebugPortGetter/Setter to node_process.cc

    PR-URL: nodejs#22758
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    jasnell authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    27b0cb5 View commit details
    Browse the repository at this point in the history
  9. doc: fix typo in dns docs

    PR-URL: nodejs#22866
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    MohammedEssehemy authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    4ba80b1 View commit details
    Browse the repository at this point in the history
  10. doc: add withFileTypes option to fsPromises.readdir

    PR-URL: nodejs#22833
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    bengl authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    da86003 View commit details
    Browse the repository at this point in the history
  11. process: generate list of allowed env flags programmatically

    Avoids having a separate, second source of truth on this matter.
    
    Backport-PR-URL: nodejs#22847
    PR-URL: nodejs#22638
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    addaleax authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    1e07002 View commit details
    Browse the repository at this point in the history
  12. lib: generate allowedNodeEnvironmentFlags lazily

    Backport-PR-URL: nodejs#22847
    PR-URL: nodejs#22638
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    addaleax authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    a793163 View commit details
    Browse the repository at this point in the history
  13. doc: add full deprecation history

    I tried to manually reconstruct the history of deprecations and to
    track them down to their origins. Having these documented publicly
    makes it much easier to find out when deprecations were introduced
    or changed.
    
    Backport-PR-URL: nodejs#22826
    PR-URL: nodejs#22766
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    81fd5d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. fs: fix promisified fs.readdir withFileTypes

    PR-URL: nodejs#22832
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    apapirovski authored and targos committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    479e1ec View commit details
    Browse the repository at this point in the history
  2. src: fix --prof-process CLI argument handling

    Make sure that options after `--prof-process` are not treated
    as Node.js options.
    
    Fixes: nodejs#22786
    
    PR-URL: nodejs#22790
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    addaleax authored and targos committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    f2ae0cb View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. tracing: remove shutdown-on-signal

    This feature cannot be reasonably implemented this way
    without inherently being susceptible to race conditions
    that lead to hangs, crashes, etc.
    
    What’s more, implementing this for some signals only
    (and it can only be implemented for some signals at all)
    may lead to the impression that it is a guaranteed
    feature, when really consumers of the tracing output
    *need* to be able to handle abrupt ends meaningfully.
    
    Fixes: nodejs#14802
    Fixes: nodejs#22528
    
    PR-URL: nodejs#22734
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    addaleax authored and targos committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    9441282 View commit details
    Browse the repository at this point in the history
  2. path: remove unnecessary if statement

    There is an `if`-statement in `normalizeString` (a helper function for
    `path.normalize`) whose `else`-branch is never taken. This patch
    removes it.
    
    PR-URL: nodejs#22273
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    wchargin authored and targos committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    14c491c View commit details
    Browse the repository at this point in the history
  3. tools: update ESLint to 5.6.0

    Update ESLint to 5.6.0.
    
    PR-URL: nodejs#22882
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and targos committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    7c5e0d8 View commit details
    Browse the repository at this point in the history
  4. src: move no_async_hooks_checks to env

    This commit moves the setting of AsyncHooks no_force_checks to the
    Environment constructor instead of from the Start function in node.cc.
    
    PR-URL: nodejs#22784
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and targos committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    3b763cd View commit details
    Browse the repository at this point in the history
  5. [v10.x backport] backport d48bd16 from v8 master

    Junliang Yan committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    182ec37 View commit details
    Browse the repository at this point in the history
  6. update patch level

    Conflicts:
    	deps/v8/include/v8-version.h
    Junliang Yan committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    9164ccf View commit details
    Browse the repository at this point in the history
  7. Revert "update patch level"

    This reverts commit 9164ccf.
    Junliang Yan committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    d0166ea View commit details
    Browse the repository at this point in the history
  8. update embedder string

    Junliang Yan committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    ce43fb1 View commit details
    Browse the repository at this point in the history