Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.14.1 proposal #24832

Merged
merged 88 commits into from
Dec 18, 2018
Merged

v8.14.1 proposal #24832

merged 88 commits into from
Dec 18, 2018

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Dec 4, 2018 •
edited by MylesBorins
Loading

2018-12-18, Version 8.14.1 'Carbon' (LTS), @MylesBorins prepared by @BethGriggs

Notable changes

  • assert:
    • revert breaking change (Ruben Bridgewater) #24786
  • http2:
    • fix sequence of error/close events (Gerhard Stoebich) #24789

Commits

Vasili Skurydzin and others added 30 commits November 28, 2018 11:26
@rvagg
deps: cherry-pick 6bc4bfe from V8 upstream
9bedae5 
Only changes to src/base/debug/stack_trace_posix.cc included

Original commit message:
    Fixes to V8 GN build process on aix platform

    src/base/debug/stack_trace_posix.cc: suppressed unused function warnings
    for functions DemangleSymbols, OutputPointer(in order to compile with
    -Werror flag)

    test/cctest/test-isolate-independent-builtins.cc: corrections to make
    ByteInText test case compatible with aix. (affects aix only)

    Change-Id: I49e45e63545404c77aaed3f51b26557f6f03455e
    Reviewed-on: https://chromium-review.googlesource.com/927484
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52071}

PR-URL: #23958
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@rvagg
deps: cherry-pick d2e0166 from V8 upstream
5034729 
    Original commit message:

    ppc64, aix: Pass CallFrequency object by const reference to avoid value copy error.

    Bug: v8:8193
    GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976

    Change-Id: I0d4efca4da03ef82651325e15ddf2160022bc8de
    Reviewed-on: https://chromium-review.googlesource.com/1228633
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Reviewed-by: Daniel Clifford <danno@chromium.org>
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#56275}

PR-URL: #23958
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@rvagg
deps,v8: fix gyp build on Aix platform
4f3c9e6 
Floating this patch since the code does not exist upstream anymore.

deps/v8/testing/gtest.gyp:
Supperss -Wnonnull-compare, -Waddress warnings for deps/v8/testing/gtest
project;

deps/v8/src/compiler/store-store-elimination.cc, deps/v8/src/conversions.cc:
Suppress unused function warnings in order to compile with newer (>4.8.5)
gcc on Aix.

PR-URL: #23958
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@jasnell @rvagg
doc: remove reference to sslv3 in tls.md
e2d2ce6 
PR-URL: #23745
Fixes: #9822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Aiden01 @rvagg
test: fix assertion arguments order
544e64d 
PR-URL: #23787
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@sam-github @rvagg
test: ensure openssl version prints correctly
73d19b1 
PR-URL: #23678
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@fraxken @rvagg
test: fix strictEqual() arguments order
0f98c49 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RomainLanz @rvagg
test: fix strictEqual() argument order
ac91346 
PR-URL: #23768
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@bzoz @rvagg
test: fix test-require-symlink on Windows
e7a573a 
Creating directory symlinks on Windows require 'dir' parameter to be
provided.

Fixes: #23596

PR-URL: #23691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell @rvagg
doc: document that addMembership must be called once in a cluster
32ae851 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jasnell @rvagg
doc: document ACL limitation for fs.access on Windows
0ff88a3 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@jasnell @rvagg
doc: add note about removeListener order
e5f75cf 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@phillipj @rvagg
doc: move @phillipj to emeriti
f037942 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295 @rvagg
deps: icu: apply workaround patch
34d9129 
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@danbev @rvagg
crypto: add SET_INTEGER_CONSANT macro
4996056 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@ErickWendel @rvagg
doc: add review suggestions to require()
3f2a016 
PR-URL: #23605
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg
test: fix strictEqual() arguments order
3a864d7 
PR-URL: #23800
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@codebytere @rvagg
build: allow for overwriting of use_openssl_def
f70e79a 
PR-URL: #23763
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax @rvagg
build: initial .travis.yml implementation
7612024 
Refs: ayojs/ayo#14
Refs: ayojs/ayo#75
Co-authored-by: Jeremiah Senkpiel <fishrock123@rocketmail.com>

PR-URL: #21059
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau @rvagg
build: install markdown linter for travis
1da04c2 
Run `make lint-md-build` to install the markdown linter.

PR-URL: #21215
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@TimothyGu @rvagg
build: improve Travis CI settings
2674336 
Remove macOS-specific steps, and reduce warnings due to compilation with
clang.

PR-URL: #21459
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@refack @rvagg
build,tools: tweak the travis config
313ef6f 
PR-URL: #22417
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos @rvagg
build,doc: remove outdated lint-md-build
15d1f67 
- In release guide
- In Travis config

Refs: #20109

PR-URL: #22991
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott @rvagg
tools: apply linting to first commit in PRs
c15d236 
Use Travis-CI to check the formatting of the first commit in a pull
request. This will hopefully reduce formatting errors and nits about
them in pull requests.

PR-URL: #22452
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
@Trott @rvagg
tools: make Travis commit linting more robust
2a8a28c 
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott @rvagg
tools: do not lint commit message if var undefined
22043cc 
Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit
messages in Travis CI.

Refs: #23572 (comment)
Refs: #22842 (comment)

PR-URL: #23725
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@Trott @rvagg
tools: clarify commit message linting
02209c5 
Clarify in Travis results that the commit message linting is for the
commit message and not something else.

PR-URL: #23742
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@refack @rvagg
build,meta: switch to gcc-4.9 on travis
85a6dae 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ZYSzys @rvagg
doc: simplify path.basename() on POSIX and Windows
9afdc09 
PR-URL: #23864
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lveteau @rvagg
test: fix strictEqual() argument order
d0368b8 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@richardlau
Copy link
Member

Just for awareness, for Node.js 8.x the start of maintenance date was brought forward from April 2019 to January 2019 (nodejs/Release#376), so this is the last planned active release of Node.js 8.x before it enters maintenance (during which

only critical bugs, critical security fixes, and documentation updates will be permitted.

).

BethGriggs added a commit that referenced this pull request Dec 4, 2018
@BethGriggs
2018-12-18, Version 8.14.1 'Carbon' (LTS)
5c7cb53 
Notable changes:

* Coming soon

PR-URL: #24832
@BethGriggs
Copy link
Member Author

BethGriggs commented Dec 4, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19206/ [Passed]
V8CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1915/ [Passed]

@BethGriggs
Copy link
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1666/

@BethGriggs
Copy link
Member Author

rc1: https://nodejs.org/download/rc/v8.14.1-rc.1/

@BridgeAR
Copy link
Member

BridgeAR commented Dec 5, 2018

@BethGriggs would you be so kind and include #24786 in this release? The longer the change stays in an release, the less it makes sense to actually revert it.

aautio and others added 5 commits December 10, 2018 12:36
@aautio @MylesBorins
doc: fix api documentation of http.createServer
6922231 
Fixes: #24105

PR-URL: #24869
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Tiriel @MylesBorins
doc: add description for inspector-only console methods.
74c1074 
Description inspired by dev tools reference and inspector err messages

Added:
* intro
* console.debug()
* console.dirxml()
* console.markTimeline()
* console.profile()
* console.profileEnd()
* console.table()
* console.timeStamp()
* console.timeline()
* console.timelineEnd()

PR-URL: #17004
Fixes: #16755
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR @BethGriggs
assert: revert breaking change
62fb5db 
It was not intended to change the `assert.doesNotThrow()` message
with #23223. This reverts the
breaking behavior to the one before.

PR-URL: #24786
Refs: #23223
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@MylesBorins @BethGriggs
test: verify order of error in h2 server stream
394cb42 
Currently the order of error / closing of an h2 stream is consistent
in 10.x, 11.x, and master. There appears to be an unexpected behavior
difference in 8.x. This test will be used to bisect the commit that will
fix this behavior change and ensure there are no future regressions.

PR-URL: #24685
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Flarna @BethGriggs
http2: fix sequence of error/close events
4c24a82 
Correct sequence of emitting `error` and `close` events for a
`Http2Stream`.

PR-URL: #24789
Refs: #22850
Refs: #24685
Fixes: #24559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 11, 2018
@BethGriggs
2018-12-18, Version 8.14.1 'Carbon' (LTS)
9fc8d9a 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832
@BethGriggs
Copy link
Member Author

BethGriggs commented Dec 11, 2018 •
edited
Loading

CI2: https://ci.nodejs.org/job/node-test-pull-request/19424 [Passed, Windows passed on rerun]
V8CI2: https://ci.nodejs.org/job/node-test-commit-v8-linux/1931/ [Passed]

@MylesBorins
Copy link
Contributor

rc2: https://nodejs.org/download/rc/v8.14.1-rc.2/

@MylesBorins
Copy link
Contributor

citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1689/

@Trott
Copy link
Member

Trott commented Dec 17, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19611/ ✔️

@MylesBorins
Copy link
Contributor

As I'll be the one promoting this release I've gone ahead and updating the original post and the changelog to reflect this.

Kicked off the ci-release build and will promote the assets in the a.m.

@BethGriggs @MylesBorins
2018-12-18, Version 8.14.1 'Carbon' (LTS)
187694e 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832
@MylesBorins MylesBorins merged commit 187694e into v8.x Dec 18, 2018
MylesBorins added a commit that referenced this pull request Dec 18, 2018
@MylesBorins
Working on v8.14.2
b0c4207 
PR-URL: #24832
MylesBorins pushed a commit that referenced this pull request Dec 18, 2018
@BethGriggs @MylesBorins
2018-12-18, Version 8.14.1 'Carbon' (LTS)
1cbd377 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832
@MylesBorins MylesBorins mentioned this pull request Dec 18, 2018
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BethGriggs @refack
2018-12-18, Version 8.14.1 'Carbon' (LTS)
d28c3af 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [nodejs#24786](nodejs#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [nodejs#24789](nodejs#24789)

PR-URL: nodejs#24832
@BethGriggs BethGriggs deleted the v8.14.1-proposal branch March 5, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.