Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change Fixes: to Refs: #34568

Merged
merged 19 commits into from
Aug 2, 2020
Merged

test: change Fixes: to Refs: #34568

merged 19 commits into from
Aug 2, 2020

Commits on Jul 30, 2020

  1. test: remove unneeded flag check in test-vm-memleak

    The `common` module checks that necessary flags are being used, so a
    check in the test itself is no longer necessary.
    
    PR-URL: nodejs#34528
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    2d2a812 View commit details
    Browse the repository at this point in the history
  2. Revert "module: disable cjs snapshotting into esm loader"

    This reverts commit 1fe39f0.
    
    PR-URL: nodejs#34562
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    devsnek committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    dc00a07 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. src: fix unused namespace member in node_util

    PR-URL: nodejs#34565
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    puzpuzpuz authored and addaleax committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    1e47051 View commit details
    Browse the repository at this point in the history
  2. quic: use OpenSSL built-in cert and hostname validation

    PR-URL: nodejs#34533
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    jasnell committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a97b5f9 View commit details
    Browse the repository at this point in the history
  3. n-api: simplify bigint-from-word creation

    Macro `CHECK_MAYBE_EMPTY_WITH_PREAMBLE()` does the work of checking
    the `TryCatch` and returning `napi_pending_exception` so this change
    reuses it for `napi_create_bigint_words()`.
    
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    PR-URL: nodejs#34554
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    0cc2a54 View commit details
    Browse the repository at this point in the history
  4. build: auto start Jenkins CI via PR labels

    Add an Action that will find every PR with the `request-ci` label and
    will start a Jenkins CI for each of these Pull Requests. The scheduler
    event is used to circumvent GitHub Actions limitations on Pull Requests
    from forks (where secrets are not accessible and the GITHUB_TOKEN is
    read-only).
    
    If the Action fails to start a CI, it will add a `request-ci-failed`
    label and will leave a comment with the error message from NCU.
    
    Fixes: nodejs/github-bot#234
    
    PR-URL: nodejs#34089
    Reviewed-By: Christian Clauss <cclauss@me.com>
    mmarchini committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    6cab3b0 View commit details
    Browse the repository at this point in the history
  5. doc: update .mailmap for mmarchini

    PR-URL: nodejs#34586
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mmarchini committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    c8c2f4d View commit details
    Browse the repository at this point in the history
  6. doc: update mmarchini contact info

    PR-URL: nodejs#34586
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mmarchini committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    f5df3c2 View commit details
    Browse the repository at this point in the history
  7. doc: add mmarchini pronouns

    PR-URL: nodejs#34586
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mmarchini committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    8b3ad75 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2020

  1. n-api: support type-tagging objects

    `napi_instanceof()` is insufficient for reliably establishing the data
    type to which a pointer stored with `napi_wrap()` or
    `napi_create_external()` inside a JavaScript object points. Thus, we
    need a way to "mark" an object with a value that, when later retrieved,
    can unambiguously tell us whether it is safe to cast the pointer stored
    inside it to a certain structure.
    
    Such a check must survive loading/unloading/multiple instances of an
    addon, so we use UUIDs chosen *a priori*.
    
    Fixes: nodejs#28164
    Co-authored-by: Anna Henningsen <github@addaleax.net>
    PR-URL: nodejs#28237
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Gabriel Schulhof and addaleax committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    cc7ec88 View commit details
    Browse the repository at this point in the history
  2. doc: use consistent capitalization for addons

    Sometimes _addon_ is capitalized and sometimes not. Capitalizing it
    seems peculiar and hard to justify. Standardize on treating it like
    other common nouns.
    
    PR-URL: nodejs#34536
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Trott committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    3e9caaf View commit details
    Browse the repository at this point in the history
  3. doc: simplify and clarify console.assert() documentation

    PR-URL: nodejs#34544
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    3b9a252 View commit details
    Browse the repository at this point in the history
  4. doc: use consistent spelling for "falsy"

    We use "falsy" in multiple places in our docs, but only use "false-y" in
    one place in url.md. Replace it with "falsy".
    
    PR-URL: nodejs#34545
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    770a02d View commit details
    Browse the repository at this point in the history
  5. http: provide keep-alive timeout response header

    In http 1.1 persistent connection protocol there is a
    timing race where the client sends the request and then
    the server kills the connection (due to inactivity)
    before receiving the client's request.
    
    By providing a keep-alive header it is possible to provide
    the client a hint of when idle timeout would occur and
    avoid the race.
    
    Fixes: nodejs#34560
    
    PR-URL: nodejs#34561
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
    ronag committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    849d9e7 View commit details
    Browse the repository at this point in the history
  6. build: fix auto-start-ci script path

    PR-URL: nodejs#34588
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    mmarchini committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    4268c61 View commit details
    Browse the repository at this point in the history
  7. build: don't run auto-start-ci on push

    PR-URL: nodejs#34588
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    mmarchini committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    9b6c16c View commit details
    Browse the repository at this point in the history
  8. esm: fix hook mistypes and links to types

    Prior to this commit, the custom loader hooks were:
    * missing the Node.js API ref docs types
    * missing the function signature from their sections
    * linking directly to the specification (not customary)
    * had an inconsistent non-nullable JSDoc promise return
    * had JSDoc object properties that weren't alpha-sorted
    * designated set of non-nullable types when single was fine
    
    Notes:
        https://www.typescriptlang.org/play/index.html?strictNullChecks=true&useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkftAeyIATArgJDsALkgBCAILJUATwA8eQqQB8AGl58kyakVwBVAEoAZGbIAUG4iUgAfSAFcR1JkWrCAlHrQkGQUgibUAB64vByoGJgAYh604kIUwl6IbgA2uObU2ALZAG7UMUa4bshE2FgACsgCaATY1KqY7sjZMg6kwVpkbMDgkfACyLiQiNjKRLSQDMmpRJBGhSXU9jT0TCw6kGG4kbj7GQxZufnrpX5YUAeSkx2GxmZWkAC8kEQ52cGfD3CUQA3PdGJBbABZRC4AAWADpUCImrZblpIAAGeEAVluHWAwEgAGUmtRAaJlvD7nwCZAEuNKKTIAzENk-lQ6IxmMhsKcBIy0GTaG48E1INkBCQCPMGAy1kVio4qXwaYT5NkAO6IZS1CpVFaIFYCABGACs6JMBAxIHCybLkPEqt1IOp8I4BsqVXrqncVSqnTIXiYLJZIAB+al+77UDWQENbTm7ZD7INvSx+eGwozWqSRv0+WPxjk7bkZrNeQIqsigviDPjgqEwhFI4Qo26qTE4vGQWnyIgCW3IcliCRET2qyAAdVhxgOrOyjkgAAMzhc8gUFdQl-tbVNkCQ3IKTLVaIbIMayWgBKJdsJ4ZAAJIrOEtSO00+tSBiADktUQwlEPpDQHGch2KVk3DtBk0BhWhYUXMIKVHVlIFGcZcGwcdVmoSofVXHJ12uTZiy5PZfSjeFKMOY5Kz9RCR0kGQAG1KPhaiojYoQkMkfZv2AwcAFp6OWb8AF1aOCPwa2Ce5aQAES8FgbX5AA5a9qHhU1antKY2WZQdKG2UieU9b0Vnwy4Nw2BMSzI9iTkgCzCM3KTwDIIA
        https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520conditions%253A%2520!Array%253Cstring%253E%252C%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520url%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257D
    
    PR-URL: nodejs#34240
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    DerekNonGeneric authored and Trott committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    45fa216 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2020

  1. doc: revise N-API versions matrix text

    Revise text for clarity, brevity, and conformance with our style guide.
    
    PR-URL: nodejs#34566
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    aeaf161 View commit details
    Browse the repository at this point in the history
  2. test: change Fixes: to Refs:

    Tests don't fix things generally, so use "Refs:" to refer people to
    GitHub issues.
    
    PR-URL: nodejs#34568
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    73d713b View commit details
    Browse the repository at this point in the history