Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove librt library dependency for Android compatibility #51632

Merged
merged 1 commit into from
Feb 25, 2024
Merged

build: remove librt library dependency for Android compatibility #51632

merged 1 commit into from
Feb 25, 2024

Conversation

MeowShe
Copy link
Contributor

@MeowShe MeowShe commented Feb 1, 2024 •
edited
Loading

On Android, unlike Linux, there are no separate libpthread or librt libraries. That functionality is included directly in libc, which does not need to be explicitly linked against. (Native APIs | Android NDK)

Fix: #50184

Remove librt library dependency when building Node.js for Android, as it does not exist on Android.

Related to PR #51646, as part of a series of build fixes for Android.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Feb 1, 2024
@MeowShe MeowShe changed the title build: remove librt lib link for Android compatibility build: remove librt library dependency for Android compatibility Feb 1, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57038/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5798/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5798/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5798/

@MeowShe MeowShe mentioned this pull request Feb 4, 2024
Closed
@MeowShe
Copy link
Contributor Author

MeowShe commented Feb 5, 2024

Could we re-request CI again?

@MeowShe MeowShe closed this Feb 10, 2024
@MeowShe MeowShe reopened this Feb 10, 2024
@lpinca
Copy link
Member

lpinca commented Feb 12, 2024

Could we re-request CI again?

It is under security embargo.

@MeowShe MeowShe mentioned this pull request Feb 13, 2024
Open
@MeowShe
Copy link
Contributor Author

MeowShe commented Feb 14, 2024

Could we re-request CI again?

It is under security embargo.

Anything should I do for that?

@lpinca
Copy link
Member

lpinca commented Feb 14, 2024

No, thank you.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57092/

@lpinca lpinca mentioned this pull request Feb 24, 2024
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57391/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 56ced19 into nodejs:main Feb 25, 2024
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 56ced19

@MeowShe MeowShe deleted the android-v8_gypfiles branch February 26, 2024 04:19
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@MeowShe @marco-ippolito
build: remove librt libs link for Android compatibility
3337eef 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@MeowShe @marco-ippolito
build: remove librt libs link for Android compatibility
6093759 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
@MeowShe @marco-ippolito
build: remove librt libs link for Android compatibility
c9ada53 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MeowShe @richardlau
build: remove librt libs link for Android compatibility
8208e99 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MeowShe @richardlau
build: remove librt libs link for Android compatibility
4118174 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@MeowShe @rdw-msft
build: remove librt libs link for Android compatibility
750d566 
PR-URL: nodejs#51632
Fixes: nodejs#50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v8: "ld.lld: error: unable to find library -lrt" when building for android aarch64
4 participants
@MeowShe @nodejs-github-bot @lpinca @joyeecheung