repl: Failed to save editor mode text in .save command
#8145
Conversation
|
|
||
| putIn.run([`.save ${saveFileName}`]); | ||
| replServer.close(); | ||
| assert.equal(fs.readFileSync(saveFileName, 'utf8'), `${cmds.join('\n')}\n`); |
There was a problem hiding this comment.
assert.strictEqual() please.
|
LGTM with green CI |
Fishrock123
added
the
semver-minor
|
sounds like a tiny feature to me if you think otherwise, remove the label I guess |
princejwesley
force-pushed
the
repl.8142
branch
from
e791fef to
6b3b5cb
Compare
|
CI is green except for one build bot failure. LGTM, and I think this can pass as as semver-patch change. |
|
I'd say semver-patch. It seems obvious to me that this should have worked before but it was just missed. |
addaleax
removed
the
semver-minor
|
@addaleax Is it good for merging or one more attempt for CI green? |
|
@princejwesley I think this is good to go. 👍 |
|
Landed in f6a7434 |
|
The status line for this commit is not great. Its goal is to inform the reader what changed and why but The lack of commit log exacerbates it. The only way to divine what really changed is to look at the diff. |
|
@bnoordhuis Shall I amend the commit with below description ?
Sorry, I should have added it in the first place |
|
Too late now, we're well outside the 10 minute rule. :-) |
|
Introducing a rebasing and pre-review before landing might avoid this kind of issue again? |
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **meta**: add @joshgav to collaborators (Josh Gavant) #8146 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
repl
Description of change
Fixes: #8142
Note: This pull request depends on #8143 to merge in order to pass the test.