inspector: add support for uncaught exception #8043
Conversation
nodejs-github-bot
added
c++
|
This pull request is based on latest version of V8Inspector that hasn't pushed to master yet https://github.com/eugeneo/node/commit/2864bfdbf1d8448e4286b402b90a54bc3c2e36ef. I checked lint and test on latest version of V8Inspector. |
| return String16(); | ||
| } | ||
| v8::Local<v8::String> string_value = v8::Local<v8::String>::Cast(value); | ||
| std::unique_ptr<UChar[]> buffer(new UChar[string_value->Length()]); |
There was a problem hiding this comment.
You probably cannot use std::unique_ptr as long as we still support OS X 10.8 and 10.9.
(I'm not 100% sure about 10.9 but 10.8 certainly doesn't have it, not even in tr1.)
There was a problem hiding this comment.
I suspect this may be using the std::unique_ptr leaking out of the v8_inspector headers. A fake stl implementation was added to allow v8_inspector to work w/ Node.js v6.x. I can build this on my mac, with the Node.js build default of -mmacosx-version-min=10.7.
|
Thanks! |
| v8::Local<v8::Context> context = env->context(); | ||
|
|
||
| int script_id = message->GetScriptOrigin().ScriptID()->Value(); | ||
| std::unique_ptr<blink::V8StackTrace> stack_trace = |
There was a problem hiding this comment.
Can you replace the std::unique_ptr?
There was a problem hiding this comment.
I need to get this pointer, use it to check scriptId and then pass it back to V8Inspector::exceptionThrown API call and I prefer to use unique_ptr here.
I can use auto instead of unique_ptr to hide real type of stackTrace. WDYT?
There was a problem hiding this comment.
Looks like @ofrobots is right that it picks up a non-system std::unique_ptr because this PR builds for me on OS X 10.8. If you want to restore the other use, go ahead.
|
I've rebased. It's ready for real review. |
|
LGTM |
|
LGTM if CI is green. |
|
@ak239: there were some failures in the CI. Can you take a look? |
To output exception in DevTools console method exceptionThrown should be called on uncaught exception on V8Inspector object. Additionally we need to wait disconnect to provide user way to inspect exception.
|
I've fixed compilation and uploaded new version. |
|
LGTM. |
To output exception in DevTools console method exceptionThrown should be called on uncaught exception on V8Inspector object. Additionally we need to wait disconnect to provide user way to inspect exception. PR-URL: #8043 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
|
Thanks. Landed as 26cd48f. |
To output exception in DevTools console method exceptionThrown should be called on uncaught exception on V8Inspector object. Additionally we need to wait disconnect to provide user way to inspect exception. PR-URL: #8043 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **meta**: add @joshgav to collaborators (Josh Gavant) #8146 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector
Description of change
To output exception in DevTools console method exceptionThrown should be
called on uncaught exception on V8Inspector object.
Additionally we need to wait disconnect to provide user way to inspect
exception.