doc: Add @joshgav to collaborators. #8146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -235,6 +235,8 @@ more information about the governance of the Node.js project, see | |||
| * [joaocgreis](https://github.com/joaocgreis) - | |||
| **João Reis** <reis@janeasystems.com> | |||
| * [julianduque](https://github.com/julianduque) - | |||
| **Josh Gavant** <josh.gavant@outlook.com> | |||
| * [joshgav](https://github.com/joshgav) - | |||
There was a problem hiding this comment.
You’re inserting yourself in the middle of julianduque’s entry… not sure that’s intended? ;)
There was a problem hiding this comment.
Wow you're fast :) Already corrected.
|
LGTM |
1 similar comment
|
LGTM |
joshgav
added a commit
that referenced
this pull request
Aug 17, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #8146
|
LGTM |
|
@joshgav Looks like we overlooked the critical last step: Closing the PR with a "Landed in " comment... Sorry I didn't catch that at the time... Can you close this with the comment? |
|
landed in b417087 |
evanlucas
pushed a commit
that referenced
this pull request
Aug 20, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #8146
evanlucas
added a commit
that referenced
this pull request
Aug 24, 2016
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **meta**: add @joshgav to collaborators (Josh Gavant) #8146 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143
MylesBorins
pushed a commit
that referenced
this pull request
Sep 9, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #8146
MylesBorins
pushed a commit
that referenced
this pull request
Sep 28, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #8146
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #8146
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #8146
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Add @joshgav to collaborators.