Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Merge addon framework #176

Closed

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jun 8, 2023

Summary

This will merge the https://github.com/open-cluster-management-io/addon-framework into staging directory.

Related issue(s)

Fixes #

hanqiuzh and others added 30 commits August 24, 2020 11:35
add managedclusteraddon & clsutermanagementeaddon
* go mod tidy

* use apimachinery 0.18.4
* add doc for addon status

* address comments
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: liuwei <liuweixa@redhat.com>
Signed-off-by: liuwei <liuweixa@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
…informer

Add worker informer in agent deploy
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
haoqing0110 and others added 18 commits April 27, 2023 04:32
* update cma progressing condition

Signed-off-by: haoqing0110 <qhao@redhat.com>

* integration test case

Signed-off-by: haoqing0110 <qhao@redhat.com>

* update

Signed-off-by: haoqing0110 <qhao@redhat.com>

---------

Signed-off-by: haoqing0110 <qhao@redhat.com>
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
…n is managed by addon-manager (open-cluster-management-io#184)

Signed-off-by: haoqing0110 <qhao@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
* Add changelog 0.6.1

Signed-off-by: zhujian <jiazhu@redhat.com>

* Add changelog 0.7.0

Signed-off-by: zhujian <jiazhu@redhat.com>

---------

Signed-off-by: zhujian <jiazhu@redhat.com>
…r-management-io#183)

* support config image override by addon deployment config

Signed-off-by: zhujian <jiazhu@redhat.com>

* add e2e test for image override

Signed-off-by: zhujian <jiazhu@redhat.com>

* build and tag addon examples image

Signed-off-by: zhujian <jiazhu@redhat.com>

---------

Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

zhujian7 commented Jun 8, 2023

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhujian7
Once this PR has been reviewed and has the lgtm label, please assign jnpacker for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the open-cluster-management-io org. You can then trigger verification by writing /verify-owners in a comment.

  • pmorie
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • staging/OWNERS

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@62efbf9). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage        ?   58.46%           
=======================================
  Files           ?      107           
  Lines           ?    11836           
  Branches        ?        0           
=======================================
  Hits            ?     6920           
  Misses          ?     4244           
  Partials        ?      672           
Flag Coverage Δ
unit 58.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhujian7
Copy link
Member Author

zhujian7 commented Jun 8, 2023

/close

@openshift-ci openshift-ci bot closed this Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

@zhujian7: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ycyaoxdu pushed a commit to ycyaoxdu/ocm that referenced this pull request Jun 14, 2023
…ement-io#176)

This could make code clearer
also update the crd fix

Signed-off-by: Jian Qiu <jqiu@redhat.com>

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.