fix: a11y rule "no-noninteractive-element-interactions" #4163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dun-sin
requested review from
zeucapua,
brandonroberts and
nickytonline
as code owners
👷 Deploy request for oss-insights pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dun-sin
changed the title
nickytonline
requested changes
Oct 15, 2024
nickytonline
requested changes
Oct 15, 2024
nickytonline
approved these changes
Oct 15, 2024
nickytonline
added
the
hacktoberfest
brandonroberts
approved these changes
Oct 15, 2024
zeucapua
approved these changes
Oct 16, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
## [2.64.0-beta.4](v2.64.0-beta.3...v2.64.0-beta.4) (2024-10-16) ### 🐛 Bug Fixes * a11y rule "no-noninteractive-element-interactions" ([#4163](#4163)) ([4d26abc](4d26abc))
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
## [2.64.0](v2.63.0...v2.64.0) (2024-10-22) ### 🍕 Features * download `ContributorsTable` data as JSON/CSV ([#4151](#4151)) ([d87b37e](d87b37e)) * removed developer pack form from user settings page ([#4173](#4173)) ([da975d7](da975d7)) * removed payments and limits ([#4171](#4171)) ([898d889](898d889)) ### 🐛 Bug Fixes * a11y rule "iframe-has-title" fails with a warning. ([#4162](#4162)) ([f15764a](f15764a)) * a11y rule "img-redundant-alt" fails with a warning ([#4176](#4176)) ([cc9cdf0](cc9cdf0)) * a11y rule "no-noninteractive-element-interactions" ([#4163](#4163)) ([4d26abc](4d26abc)) * fixed changing workspaces visibility regression ([#4172](#4172)) ([ee12474](ee12474)) * Make the "create workspace" option more obvious ([#4177](#4177)) ([9d8ae39](9d8ae39)) * removed unused code ([#4178](#4178)) ([d6fff39](d6fff39)) * resolve a11y warnings for role-supports-aria-props rule ([#4174](#4174)) ([95e2099](95e2099)) * throw errors on insight creation failure ([#4145](#4145)) ([e3f8db3](e3f8db3)) * use a tags instead of link tags ([#4158](#4158)) ([7b48770](7b48770))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Ally warning caused by jsx-ally, by using buttons to replace p and div elements that have
onClickRelated Tickets & Documents
Fixes #4137
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?