[extension][ecsobserver] Init config and target definition #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2939 +/- ##
==========================================
+ Coverage 91.53% 91.55% +0.02%
==========================================
Files 464 471 +7
Lines 22799 22915 +116
==========================================
+ Hits 20868 20979 +111
- Misses 1438 1441 +3
- Partials 493 495 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
ping @jrcamp |
jrcamp
reviewed
Apr 1, 2021
pingleig
force-pushed
the
ecssd-config-defs
branch
from
bb95b8d to
f2c83c0
Compare
|
@jrcamp rebased and also bumped aws sdk version to match other components. |
jrcamp
approved these changes
Apr 2, 2021
|
ping @bogdandrutu |
4 tasks
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…metry#2939) * extension: ecssd Init config and target definition * extension: ecssd Remove unsued func and consts * extension: ecssd Update config and use lastest core
This was referenced Apr 28, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A smaller part of #2734
Init config and some struct definitions for ECS Prometheus service discovery
btw: 1.4k loc are go.sum, it only have 500 lines for config struct and some large struct for exporting.
Link to tracking Issue:
Testing:
unit test
Documentation:
No new doc, see #2377 for existing doc