Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/ecsobserver] Add exporter to convert task to target #3333

Merged
merged 7 commits into from
Jun 9, 2021
Merged

[extension/ecsobserver] Add exporter to convert task to target #3333

merged 7 commits into from
Jun 9, 2021

Conversation

pingleig
Copy link
Contributor

@pingleig pingleig commented May 6, 2021

Description:

Export discovered ECS task as Prometheus scrape targets.

Link to tracking Issue:

Pending PRs

Previous PRs

Testing:

unit test

Documentation:

No new doc. See existing doc

@pingleig pingleig requested a review from jrcamp as a code owner May 6, 2021 01:42
@pingleig pingleig requested a review from a team May 6, 2021 01:42
@pingleig
Copy link
Contributor Author

pingleig commented May 6, 2021 •
edited
Loading

cc @mxiamxia @Aneurysm9

CI failed because of cert error in some other packages

ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver/interval	0.030s
2021/05/06 01:58:31 http: TLS handshake error from 127.0.0.1:50733: remote error: tls: bad certificate
--- FAIL: TestReception (1.53s)
    --- FAIL: TestReception/connect_via_TLS_compressed_sapm (0.51s)
        trace_receiver_test.go:217: Starting

@pingleig pingleig changed the title ext: ecsobserver Add exporter to convert task to target [extension/ecsobserver] Add exporter to convert task to target May 6, 2021
@pingleig pingleig force-pushed the ecssd-exporter branch 6 times, most recently from 368ba5b to 188f98c Compare May 12, 2021 20:45
@pingleig
Copy link
Contributor Author

ping @anuraaga

@pingleig pingleig mentioned this pull request May 14, 2021
Merged
@tigrannajaryan
Copy link
Member

@jrcamp please review.

@jrcamp jrcamp self-assigned this May 19, 2021
@pingleig pingleig mentioned this pull request May 24, 2021
Merged
@bogdandrutu
Copy link
Member

Please rebase

@pingleig
ext: ecsobserver Run go mod tidy
fb29519 
sum file is updated, might caused by merging
@pingleig
Copy link
Contributor Author

pingleig commented Jun 1, 2021

@bogdandrutu rebased, thx!

mxiamxia
mxiamxia approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alolita alolita added the ready to merge Code review completed; ready to merge by maintainers label Jun 3, 2021
@bogdandrutu bogdandrutu merged commit 18cec46 into open-telemetry:main Jun 9, 2021
@pingleig pingleig mentioned this pull request Jun 14, 2021
Merged
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@bogdandrutu
Remove Export from obsreport.Exporter funcs (#3333)
4a7beef 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcamp jrcamp jrcamp left review comments

@mxiamxia mxiamxia mxiamxia approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees

@jrcamp jrcamp

@anuraaga anuraaga

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pingleig @tigrannajaryan @bogdandrutu @jrcamp @anuraaga @Aneurysm9 @mxiamxia @alolita