-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/ecsobserver] Add get ip and port from task #3133
Conversation
Please make sure the build passes. |
I think the build failed (12days ago due to dockerhub problems). I need to push new commits to address review comments so we don't need to retry the build manually (I think retry on circleci has permission requirement.)
|
Codecov Report
@@ Coverage Diff @@
## main #3133 +/- ##
==========================================
- Coverage 91.91% 91.63% -0.29%
==========================================
Files 494 487 -7
Lines 23939 23574 -365
==========================================
- Hits 22003 21601 -402
- Misses 1429 1463 +34
- Partials 507 510 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@Aneurysm9 @mxiamxia PTAL btw: build failed for load test the extension is not enabled, so it should be loadtest's own problem. Force pushed same commit to rerun the CI. From steps the CPU usage is higher than expected in load test
|
ae2df33
to
1ae299b
Compare
Based on review comments from Anthony - Add error struct for ip and port error, we can report metrics later. - MergeTarget is wrong, add unit test to make sure it is merging new target only once instead of multiply by existing targets :D - Fix typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description:
Follow up on #2734 Add get private ip and mapped port from ecs task
Link to tracking Issue:
Previous PRs
Testing:
unit test
Documentation:
No new doc. See existing doc