Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.1-beta #315

Merged
merged 56 commits into from
Nov 1, 2023
Merged

Release 0.5.1-beta #315

merged 56 commits into from
Nov 1, 2023

Conversation

tsterbak
Copy link
Member

@tsterbak tsterbak commented Oct 7, 2023

This release adds:

  • Allow flashing of the vendor_boot partition
  • Add --disable-verity --disable-verification to flash vbmeta command

New devices:

  • support for begonia (Xiaomi Redmi Note 8 Pro) (thanks to @anon1892)
  • support for on7xelte (Samsung Galaxy J7 Prime) (thanks to @MagicLike)
  • support for a7y17lte (Samsung Galaxy A7 2017) (thanks to @SirRGB)
  • support for jfltexx (Samsung Galaxy S4) (thanks to @MagicLike)
  • support for dipper (Xiaomi Mi 8) (thanks to @anon1892)
  • support for surya/karna (Poco X3 - X3 NFC) (thanks to @anon1892)
  • support for alioth (Redmi K40 / Mi 11X / Poco F3) (thanks to @anon1892)
  • new device code variant to j7elte & added TWRP link (thanks to @MagicLike)

Other improvements:

  • updates for some OnePlus and Pixel configs with make use of the flashing of additional partitions if needed for Android 13
  • a requirement checkbox to encourage booting stock OS at least once
  • migrate xda developers link to a new url
  • misc docs and minor config corrections/additions (thanks to @SirRGB)

@tsterbak tsterbak added this to the Release Beta-Version 0.5.1 milestone Oct 7, 2023
@tsterbak tsterbak self-assigned this Oct 7, 2023
@MagicLike MagicLike added the enhancement New feature or request label Oct 8, 2023
@tsterbak tsterbak added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 12, 2023
Based on reworked (working) Mi439 config in #317

Asks for `vendor_boot`, as depicted by Lineage 20 documentation. Maybe
it has to be optional, since TWRP documentation doesn't mention it?

Related to #275
Untested
)

The PR adds:
- updates for some OnePlus and Pixel configs with make use of the
flashing of additional partitions if needed for Android 13
- Allow flashing of the vendor_boot partition
- Add --disable-verity --disable-verification  to flash vbmeta command
- support for alioth (Redmi K40 / Mi 11X / Poco F3) (thanks to
@anon1892)

Resolves #303 and #304 .
@MagicLike
Copy link
Member

https://github.com/openandroidinstaller-dev/openandroidinstaller/pull/317/files/53d836b4828f022fd0d89371ac3b0265c3201bc0#r1377870986

Copy link
Member

@anon1892 anon1892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastboot reboot recovery wasn't changed to fastboot reboot-recovery here. Is this an oversight?

Else, LGTM

@tsterbak
Copy link
Member Author

fastboot reboot recovery wasn't changed to fastboot reboot-recovery here. Is this an oversight?

Should it be changed in general? I can change it in the function if you want :) I wasn't sure about it.

Else, LGTM

Great! Thanks for the quick review :)

@tsterbak
Copy link
Member Author

Should it be changed in general? I can change it in the function if you want :) I wasn't sure about it.

Both commands seem to be supported by fastboot, but only reboot recovery is in the specification as far as I can tell. But they should be largely equivalent.

@tsterbak
Copy link
Member Author

fastboot reboot recovery wasn't changed to fastboot reboot-recovery here. Is this an oversight?

Should be fine, I changed it now :)

@tsterbak
Copy link
Member Author

I will give this some more testing tomorrow and then release it :)

Thanks for the great work everyone!

README.md Outdated
Xiaomi | Redmi 9A / 9C / 9AT / 9i / 9A Sport / 10A / 10A Sport | garden / dandelion / blossom / angelican | | tested
Xiaomi | Mi 9T / Redmi K20 | [davinci](https://wiki.lineageos.org/devices/davinci) / davinciin | | untested
Xiaomi | Mi 9T / Redmi K20 | [davinci](https://wiki.lineageos.org/devices/davinci) / davincin | | untested
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not good 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now, I hope 😬

@anon1892
Copy link
Member

Add --disable-verity --disable-verification to flash vbmeta command

What does that change? It's not needed for actually supported Xiaomi devices, afaik

@tsterbak
Copy link
Member Author

What does that change? It's not needed for actually supported Xiaomi devices, afaik

This seems to be recommended by TWRP for a lot of recent devices, also Xiaomi:

@anon1892
Copy link
Member

Ok, thanks!

@MagicLike
Copy link
Member

I'd really like to have #337 included...

@tsterbak
Copy link
Member Author

I'd really like to have #337 included...

Yeah, the changes would be nice. But it's not blocking for the release, since changes to the README can me done without a release.

Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsterbak tsterbak merged commit fe5644f into main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants