Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dspv2 merge - Sprint 9 Check-in Merge 2 #521

Merged
merged 26 commits into from
Jan 8, 2024
Merged

Dspv2 merge - Sprint 9 Check-in Merge 2 #521

merged 26 commits into from
Jan 8, 2024

Conversation

gmfrasca
Copy link
Member

The issue resolved by this Pull Request:

Resolves #471

Description of your changes:

Pull in changes from main branch, Nov 15 - Dec 19

Testing instructions

Run standard sanity checks

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

gmfrasca and others added 24 commits November 15, 2023 16:51
@gmfrasca
Improve Container Env Comparison in FuncTests
797077f
@openshift-merge-bot
Merge pull request opendatahub-io#463 from gmfrasca/improve-envcompare
b8e5b06 
Improve Container Env Comparison in FuncTests
@VaniHaripriya
Added storageClassName in the PVCs for Minio and MariaDB
05f7cd7 
Removed unwanted change

Fixed precommit issue

Update description of StorageClassName
@DharmitD
Adding a variable for minio-service endpoint
3708e65
@diegolovison
Update Pre-requisites to Openshift 4.11+
c4c86df
@openshift-merge-bot
Merge pull request opendatahub-io#479 from DharmitD/minio-endpt-svc
5dbf012 
Adding a variable for minio-service endpoint
@hbelmiro
Replaced kfdefs with DataScienceCluster resource and changed default …
745d8dd 
…ns to opendatahub

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro
Restored removed code from upgrade-test.yml
049311c 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@cam-garrison
add flag service oauth port
dca7735
Extracted DB and Object Storage Logs to display on DSPA
f9410d8 
Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
@openshift-merge-bot
Merge pull request opendatahub-io#483 from hbelmiro/issue-453
30e8efc 
 Replaced kfdefs with DataScienceCluster resource and changed default ns to opendatahub
@openshift-merge-bot
Merge pull request opendatahub-io#487 from amadhusu/am/451
325b3e8 
Extracted DB and Object Storage Error Logs to display on DSPA
@openshift-merge-bot
Merge pull request opendatahub-io#491 from cam-garrison/oauth-flag-se…
f6dbcdc 
…rvice

Add flag to APIServer service's oauth port
@VaniHaripriya
Updated pvc.yaml.tpl to handle storageClassName
6f38c05
@openshift-merge-bot
Merge pull request opendatahub-io#464 from VaniHaripriya/issue-192
28dbeb8 
Added storageClassName in the PVCs for Minio and MariaDB
@HumairAK
fix: propogate external conn errors as string msgs.
2ba42fb 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Merge pull request opendatahub-io#506 from HumairAK/issue_505
569d614 
fix: DSPO crashes when external connections failed
@HumairAK
Correct pvc storageclass indentation.
09f0346 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Update owners.
84908fb 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Merge pull request opendatahub-io#510 from HumairAK/update_owners
061c5ad 
Update owners.
@gmfrasca
Merge remote-tracking branch 'odh/main' into dspv2-merge
fa6b567
@openshift-merge-bot
Merge pull request opendatahub-io#509 from HumairAK/issue_508
f4d5a02 
Correct pvc storageclass indentation.
@HumairAK
Merge pull request opendatahub-io#485 from diegolovison/diegolovison-…
3678752 
…patch-1

Update Pre-requisites to Openshift 4.11+
@gmfrasca
Merge remote-tracking branch 'odh/main' into dspv2-merge
a1fc85c
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-521
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/521/head
git checkout -b pullrequest a1fc85c56bbd667462a139195717cc59c6b05368
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-521"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-521

@gmfrasca gmfrasca mentioned this pull request Dec 21, 2023
Closed
rimolive
rimolive reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Deployment went fine, and the iris-pipeline example ran successfuly

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2024
@HumairAK
Copy link
Contributor

HumairAK commented Jan 8, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dcdec26 into opendatahub-io:dspv2 Jan 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimolive rimolive rimolive left review comments

@amadhusu amadhusu Awaiting requested review from amadhusu

Assignees

@rimolive rimolive

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gmfrasca @dsp-developers @HumairAK @rimolive @VaniHaripriya @DharmitD @diegolovison @hbelmiro @cam-garrison