Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) fix encounter location submission handler bug #228

Merged
merged 16 commits into from
May 1, 2024
Merged

(fix) fix encounter location submission handler bug #228

merged 16 commits into from
May 1, 2024

Conversation

arodidev
Copy link
Contributor

@arodidev arodidev commented Apr 25, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR is a failsafe which fixes a bug that occurs when the getDisplayValue does not exist.

Screenshots

image-20240418-111105

Related Issue

Other

@samuelmale
Copy link
Member

@arodidev did you see the build failure? Very likely to be unrelated to your changes but can we have a clean build?

arodidev and others added 11 commits April 29, 2024 11:08
@arodidev
Merge branch 'main' of https://github.com/arodidev/openmrs-form-engin…
95828f7 
…e-lib into encounter-location-submission-handler-fix
@kajambiya @arodidev
(feat) O3-3007: Add support for saving patient identifiers in forms (o…
02f5bbe 
…penmrs#202)

* Add support for saving patient identifiers in forms

* Address review comments

* resolve conflicts

* fix failing tests
@pirupius @arodidev
(feat) O3-3109 deprecate type within inbuiltControls (openmrs#229)
3c42609
@samuelmale @arodidev
(test) Fix intermittently failing tests (openmrs#231)
8ef8e88
@samuelmale @arodidev
(feat) Update AFE transformer to handle aliases (openmrs#221)
b94f5a0
@pirupius @arodidev
(chore) Switch @carbon/react to peer dependency (openmrs#236)
0cec95f
@arodidev
(fix) fix tooltip alignment on obsGroup (openmrs#235)
9b9b731 
* fix tooltip styles on obsGroup

* cleanup
@vasharma05 @arodidev
(feat) Fetch all concept references of the the form with SWR Infinite (…
dc76bf4 
…openmrs#241)

* Fetching all concepts references with useSWRInfinite

* Fixed failing tests
@arodidev
Failsafe incase display object doesn't exist
51a87f6
@arodidev
linting
af33d4b
@arodidev
Merge branch 'encounter-location-submission-handler-fix' of https://g…
75fcac1 
…ithub.com/arodidev/openmrs-form-engine-lib into encounter-location-submission-handler-fix
@samuelmale samuelmale merged commit daea8e2 into openmrs:main May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmale samuelmale samuelmale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arodidev @samuelmale @kajambiya @pirupius @vasharma05