Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3109 deprecate type within inbuiltControls #229

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

pirupius
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Previously both name and type were defined but the name wasn't being used. The optional type was the one being referenced. This PR deprecates replaces the value of type to the name and deprecates the type

Perviously

{
  name: 'Radio',
  component: Radio,
  type: 'radio',
},

Now

{
  name: 'radio',
  component: Radio,
},

Screenshots

Related Issue

Other

Copy link

Size Change: -223 B (0%)

Total Size: 1.2 MB

ℹ️ View Unchanged
Filename Size Change
dist/17.js 16.5 kB 0 B
dist/184.js 11.2 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 592 B 0 B
dist/327.js 1.59 kB 0 B
dist/335.js 958 B 0 B
dist/353.js 3.02 kB 0 B
dist/5.js 79.5 kB 0 B
dist/505.js 6.94 kB 0 B
dist/509.js 2.92 kB 0 B
dist/522.js 239 kB -102 B (0%)
dist/540.js 2.63 kB 0 B
dist/55.js 752 B 0 B
dist/606.js 2.23 kB 0 B
dist/635.js 14.2 kB 0 B
dist/738.js 150 kB 0 B
dist/886.js 6.89 kB 0 B
dist/99.js 692 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 442 kB -121 B (0%)
dist/openmrs-form-engine-lib.js 3.73 kB 0 B

compressed-size-action

@samuelmale samuelmale merged commit 0a4ff16 into main Apr 25, 2024
4 checks passed
@samuelmale samuelmale deleted the feat/O3-3109/deprecate-type-within-inbuiltControls branch April 25, 2024 19:39
arodidev pushed a commit to arodidev/openmrs-form-engine-lib that referenced this pull request Apr 29, 2024
samuelmale added a commit that referenced this pull request May 1, 2024
* resolving logic

* Failsafe incase display object doesn't exist

* Failsafe incase display object doesn't exist

* linting

* (feat) O3-3007: Add support for saving patient identifiers in forms (#202)

* Add support for saving patient identifiers in forms

* Address review comments

* resolve conflicts

* fix failing tests

* (feat) O3-3109 deprecate type within inbuiltControls (#229)

* (test) Fix intermittently failing tests (#231)

* (feat) Update AFE transformer to handle aliases (#221)

* (chore) Switch @carbon/react to peer dependency (#236)

* (fix) fix tooltip alignment on obsGroup (#235)

* fix tooltip styles on obsGroup

* cleanup

* (feat) Fetch all concept references of the the form with SWR Infinite (#241)

* Fetching all concepts references with useSWRInfinite

* Fixed failing tests

* Failsafe incase display object doesn't exist

* linting

---------

Co-authored-by: Jovan Ssebaggala <jssebaggala@outlook.com>
Co-authored-by: Pius Rubangakene <piruville@gmail.com>
Co-authored-by: Samuel Male <samuelsmalek@gmail.com>
Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants