-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Fetch all concept references of the the form with SWR Infinite #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +393 B (0%) Total Size: 1.13 MB ℹ️ View Unchanged
|
denniskigen
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pirupius
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vasharma05 for this 🚀
arodidev
pushed a commit
to arodidev/openmrs-form-engine-lib
that referenced
this pull request
Apr 29, 2024
…openmrs#241) * Fetching all concepts references with useSWRInfinite * Fixed failing tests
denniskigen
pushed a commit
that referenced
this pull request
Apr 29, 2024
…#241) * Fetching all concepts references with useSWRInfinite * Fixed failing tests
usamaidrsk
pushed a commit
to usamaidrsk/openmrs-form-engine-lib
that referenced
this pull request
Apr 29, 2024
…openmrs#241) * Fetching all concepts references with useSWRInfinite * Fixed failing tests
samuelmale
added a commit
that referenced
this pull request
May 1, 2024
* resolving logic * Failsafe incase display object doesn't exist * Failsafe incase display object doesn't exist * linting * (feat) O3-3007: Add support for saving patient identifiers in forms (#202) * Add support for saving patient identifiers in forms * Address review comments * resolve conflicts * fix failing tests * (feat) O3-3109 deprecate type within inbuiltControls (#229) * (test) Fix intermittently failing tests (#231) * (feat) Update AFE transformer to handle aliases (#221) * (chore) Switch @carbon/react to peer dependency (#236) * (fix) fix tooltip alignment on obsGroup (#235) * fix tooltip styles on obsGroup * cleanup * (feat) Fetch all concept references of the the form with SWR Infinite (#241) * Fetching all concepts references with useSWRInfinite * Fixed failing tests * Failsafe incase display object doesn't exist * linting --------- Co-authored-by: Jovan Ssebaggala <jssebaggala@outlook.com> Co-authored-by: Pius Rubangakene <piruville@gmail.com> Co-authored-by: Samuel Male <samuelsmalek@gmail.com> Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Currently, out of all concept references, only the top 50 references are fetched. With
useSWRInfinite
we can fetch all the concept references for the form in batches.Screenshots
Before
After
Related Issue
None
Other