Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Fetch all concept references of the the form with SWR Infinite #241

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

vasharma05
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Currently, out of all concept references, only the top 50 references are fetched. With useSWRInfinite we can fetch all the concept references for the form in batches.

Screenshots

Before

After

Related Issue

None

Other

Copy link

github-actions bot commented Apr 26, 2024

Size Change: +393 B (0%)

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
dist/17.js 16.6 kB 0 B
dist/184.js 11.2 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 592 B 0 B
dist/327.js 1.59 kB 0 B
dist/335.js 958 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.36 kB 0 B
dist/422.js 3.03 kB 0 B
dist/439.js 6.24 kB 0 B
dist/505.js 7.46 kB 0 B
dist/522.js 240 kB +233 B (0%)
dist/540.js 2.63 kB 0 B
dist/55.js 752 B 0 B
dist/569.js 2.5 kB 0 B
dist/581.js 203 kB 0 B
dist/606.js 2.23 kB 0 B
dist/635.js 14.2 kB 0 B
dist/767.js 79.1 kB 0 B
dist/886.js 6.94 kB 0 B
dist/942.js 482 B 0 B
dist/99.js 692 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 312 kB +128 B (0%)
dist/openmrs-form-engine-lib.js 3.81 kB +32 B (+1%)

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vasharma05 for this 🚀

@pirupius pirupius merged commit 5abfdc2 into main Apr 29, 2024
4 checks passed
@pirupius pirupius deleted the feat/fetching-all-concepts branch April 29, 2024 06:23
arodidev pushed a commit to arodidev/openmrs-form-engine-lib that referenced this pull request Apr 29, 2024
…openmrs#241)

* Fetching all concepts references with useSWRInfinite

* Fixed failing tests
denniskigen pushed a commit that referenced this pull request Apr 29, 2024
…#241)

* Fetching all concepts references with useSWRInfinite

* Fixed failing tests
usamaidrsk pushed a commit to usamaidrsk/openmrs-form-engine-lib that referenced this pull request Apr 29, 2024
…openmrs#241)

* Fetching all concepts references with useSWRInfinite

* Fixed failing tests
samuelmale added a commit that referenced this pull request May 1, 2024
* resolving logic

* Failsafe incase display object doesn't exist

* Failsafe incase display object doesn't exist

* linting

* (feat) O3-3007: Add support for saving patient identifiers in forms (#202)

* Add support for saving patient identifiers in forms

* Address review comments

* resolve conflicts

* fix failing tests

* (feat) O3-3109 deprecate type within inbuiltControls (#229)

* (test) Fix intermittently failing tests (#231)

* (feat) Update AFE transformer to handle aliases (#221)

* (chore) Switch @carbon/react to peer dependency (#236)

* (fix) fix tooltip alignment on obsGroup (#235)

* fix tooltip styles on obsGroup

* cleanup

* (feat) Fetch all concept references of the the form with SWR Infinite (#241)

* Fetching all concepts references with useSWRInfinite

* Fixed failing tests

* Failsafe incase display object doesn't exist

* linting

---------

Co-authored-by: Jovan Ssebaggala <jssebaggala@outlook.com>
Co-authored-by: Pius Rubangakene <piruville@gmail.com>
Co-authored-by: Samuel Male <samuelsmalek@gmail.com>
Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants