Merging 'develop' into 'main' #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dation Add 'thevalidatoR' gh-action to generate a report on the release
Removed parcats from imports, moved DT and gt to suggests, updated mans
- added more tests for visr survfit - updated visR to align with expectations - default method should not be a test. It should provide a default way of plotting objects
add_quantiles
…ase::plot and doesn't fail
Updated to GH Actions V2
* Updated estimate KM testing Updated estimate KM documentation to ensure to user knows that we allow non-CDISC. This was not clear. * Ran `usethis::use_tidy_description()` to put DESCRIPTION entries in standard order * docs * re-adding the error message that was removed. * docs Co-authored-by: shaesen2 <shaesen2@its.jnj.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* doc updates * doc updates
* Create Surv_CDISC.R * updates * doc update * Re-build README.Rmd * Update Surv_CDISC.R * Re-build README.Rmd * Update Surv_CDISC.R * Re-build README.Rmd * doc updates * Re-build README.Rmd * Update NAMESPACE * merge conflict fix * Re-build README.Rmd * updates * Re-build README.Rmd * Update test-Surv_CDISC.R * Re-build README.Rmd * readme * doc updates from review * doc updates * Update test-Surv_CDISC.R * Update testing: - consistent with CDISC philosophy - check the actual requirement - remove req T2.5 as this is not a requirement of our function, but something tested in the backend of survival * removed requirement 2.3 in TOC * change function name * Update testing Included CNSR info in estimate_KM to ensure user will restrict to 0/1 * re-documenting Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Mark Baillie <bailliem@gmail.com> Co-authored-by: shaesen2 <shaesen2@its.jnj.com>
Move lifecycle badges to under description Add questioning badge to tabelone
fix issues associated with apply_theme() function
bailliem
approved these changes
Jun 22, 2022
|
@ddsjoberg , @timtreis and @SHAESEN2 should we handle the interactive tutorial and any updates needed in a seperate issue? |
Updated PR Checklikst
It is already, missed this #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Checklist for PR reviewer
_pkgdown.ymlpkgdown::build_site(). Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Before you run, begin a fresh R session without any packages loaded.usethis::use_spell_check()runs with no spelling errors in documentationNEWS.mdbeen updated with the changes from this pull request under the heading indicating the latest version. If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")