Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure #10496

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

gaobinlong
Copy link
Collaborator

Description

The two methods testParseUsingPipelineStore and innerTestParseWithProvidedPipeline in SimulatePipelineRequestParsingTests never run, that's because testParseUsingPipelineStore has unused input parameter and innerTestParseWithProvidedPipeline doesn't start with test, this PR fix the bug and fix the test failure when running innerTestParseWithProvidedPipeline.

Related Issues

#10493

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…n and fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Compatibility status:

Checks if related components are compatible with change 1dbf91a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testUpdateOperations

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #10496 (e2fad84) into main (22ddcf1) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10496      +/-   ##
============================================
+ Coverage     71.28%   71.34%   +0.05%     
- Complexity    58480    58486       +6     
============================================
  Files          4843     4843              
  Lines        275265   275265              
  Branches      40076    40076              
============================================
+ Hits         196227   196381     +154     
+ Misses        62621    62494     -127     
+ Partials      16417    16390      -27     

see 459 files with indirect coverage changes

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

CHANGELOG.md Show resolved Hide resolved
@dblock dblock merged commit a43a166 into opensearch-project:main Oct 10, 2023
16 checks passed
@dblock dblock added the backport 2.x Backport to 2.x branch label Oct 10, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10496-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a43a16639530c50dc37fd486e67e2af999e82f65
# Push it to GitHub
git push --set-upstream origin backport/backport-10496-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10496-to-2.x.

@dblock
Copy link
Member

dblock commented Oct 10, 2023

@gaobinlong Can you please do a manual backport of this to 2.x? Let's remove the CHANGELOG line as well in that (and maybe in main too).

gaobinlong added a commit to gaobinlong/OpenSearch that referenced this pull request Oct 16, 2023
…n and fix test failure (opensearch-project#10496)

* Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a43a166)
dblock pushed a commit that referenced this pull request Oct 17, 2023
…n and fix test failure (#10496) (#10631)

* Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a43a166)
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
…n and fix test failure (opensearch-project#10496)

* Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
…n and fix test failure (opensearch-project#10496)

* Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…n and fix test failure (opensearch-project#10496)

* Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants