Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure #10631

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[Backport 2.x] Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure #10631

merged 1 commit into from
Oct 17, 2023

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Oct 16, 2023 •
edited
Loading

Description

Backport #10496 to 2.x branch.

Related Issues

#10493

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Fix some test methods in SimulatePipelineRequestParsingTests never ru…
d9e0ad0 
…n and fix test failure (opensearch-project#10496)

* Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a43a166)
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d9e0ad0

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #10631 (d9e0ad0) into 2.x (eadbef5) will increase coverage by 0.10%.
Report is 1 commits behind head on 2.x.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x   #10631      +/-   ##
============================================
+ Coverage     70.81%   70.92%   +0.10%     
- Complexity    58473    58560      +87     
============================================
  Files          4830     4830              
  Lines        276440   276440              
  Branches      40586    40586              
============================================
+ Hits         195766   196063     +297     
+ Misses        64001    63609     -392     
- Partials      16673    16768      +95

see 455 files with indirect coverage changes

@gaobinlong
Copy link
Collaborator Author

Change log is not needed for this test related PR, and all other tests have passed yet, @dblock , please help to review this backport PR, thanks!

@gaobinlong gaobinlong changed the title Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure [Backport 2.x] Fix some test methods in SimulatePipelineRequestParsingTests never run and fix test failure Oct 16, 2023
dblock
dblock approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip changelog for this, nbd.

@dblock dblock merged commit 6144217 into opensearch-project:2.x Oct 17, 2023
44 of 71 checks passed
@gaobinlong gaobinlong deleted the backport/backport-10496-to-2.x branch June 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaobinlong @dblock