Added workflow as a composite monitor #380
Conversation
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
| val workflowId: String | ||
| val version: Long | ||
| val method: RestRequest.Method | ||
| val srcContext: FetchSourceContext? |
There was a problem hiding this comment.
Why FetchSourceContext type and not a specific data model?
There was a problem hiding this comment.
Tbh - it's copy/paste from GetMonitorRequest
| data class Delegate( | ||
| val order: Int, | ||
| val monitorId: String, | ||
| val chainedFindings: ChainedFindings? = null |
There was a problem hiding this comment.
This points to one monitor, do we want a list?
There was a problem hiding this comment.
I think no. Each monitor that is currently being processed by the runner will have chainedFindings containing only one monitor - the one that was executed just before. By using the monitor id and the current workflow execution id, we will be able to find the findings (and extract the docIds) - which we can use as a filter for the current monitor execution.
Maybe the property is not named correctly - in general in chainedFindings we are not storing the monitor composition but in inputs property.
There was a problem hiding this comment.
Ahh ok, I think we should rename it to chainedFinding. Making it plural implies there should be more.
| val user: User?, | ||
| val schemaVersion: Int = NO_SCHEMA_VERSION, | ||
| val inputs: List<WorkflowInput>, | ||
| val owner: String? = "alerting" |
There was a problem hiding this comment.
Can we make this a constant like DEFAULT_OWNER?
| /** | ||
| * Context passed in delegate monitor to filter data queried by a monitor based on the findings of the given monitor id. | ||
| */ | ||
| data class ChainedFindings( |
…ding to conversation on the PR Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
| * @param request The request object | ||
| * @param listener The listener for getting response | ||
| */ | ||
| fun getWorkflow( |
There was a problem hiding this comment.
we can also add execute workflow
There was a problem hiding this comment.
We could - but then we need to extract the ExecuteWorkflowRequest.
Should I add a execute workflow method here or?
| class DeleteWorkflowRequest : ActionRequest { | ||
|
|
||
| val workflowId: String | ||
| val deleteDelegateMonitors: Boolean? |
|
|
||
| val workflowId: String | ||
| val deleteDelegateMonitors: Boolean? | ||
| val refreshPolicy: WriteRequest.RefreshPolicy |
There was a problem hiding this comment.
remove refresh policy
we shoudl alway set it as IMMEDIATE and not take input from user
|
|
||
| class GetWorkflowRequest : ActionRequest { | ||
| val workflowId: String | ||
| val version: Long |
There was a problem hiding this comment.
remove version from request. User should be able to fetch by id
| /** | ||
| * Context passed in delegate monitor to filter data queried by a monitor based on the findings of the given monitor id. | ||
| */ | ||
| // TODO - Remove the class and move the monitorId to Delegate (as a chainedMonitorId property) if this class won't be updated by adding new properties |
There was a problem hiding this comment.
No - I just added TODO according to what I discussed with Ashish:
"Yea we can leave it as is, but add a TODO to mention if this class will really be needed in the future if it wont get updated."
| * Optionally accepts chained findings context. | ||
| * */ | ||
| data class Delegate( | ||
| val order: Int, |
| @@ -21,9 +21,29 @@ class Finding( | |||
| val monitorName: String, | |||
| val index: String, | |||
| val docLevelQueries: List<DocLevelQuery>, | |||
| val timestamp: Instant | |||
| val timestamp: Instant, | |||
| val executionId: String? = null, | |||
| override val schedule: Schedule, | ||
| override val lastUpdateTime: Instant, | ||
| override val enabledTime: Instant?, | ||
| // TODO: Check how this behaves during rolling upgrade/multi-version cluster |
There was a problem hiding this comment.
that's ok we can test this before merging feature branch into main
…ed properties Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Description
Added workflow
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.