-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds workflows model and workflow actions for Alerting Plugin #439
Conversation
Codecov Report
@@ Coverage Diff @@
## main #439 +/- ##
============================================
+ Coverage 72.87% 73.67% +0.80%
- Complexity 712 804 +92
============================================
Files 113 125 +12
Lines 4711 5219 +508
Branches 606 662 +56
============================================
+ Hits 3433 3845 +412
- Misses 1024 1087 +63
- Partials 254 287 +33
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see three different names being used here in the PR - Workflows, ChainedMonitor and Composite. Wondering if we need to arrive at the consistency in naming, especially when UX and Rest APIs should be using Composite Monitors as the name.
return validationException | ||
} | ||
if (workflow.inputs.size > 1) { | ||
validationException = ValidateActions.addValidationError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some of these flows are not covered by the unit test. Consider looking into Codecov
comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see three different names being used here in the PR - Workflows, ChainedMonitor and Composite. Wondering if we need to arrive at the consistency in naming, especially when UX and Rest APIs should be using Composite Monitors as the name.
Workflow refers to the the new type of scheduled job.
Composite is the input type - it accepts a sequence of monitors to be executed as input.
Chained Monitor refers to chained monitor findings i.e. findings of one monitor are used as the source data for the next monitor which is 'chained' to it.
…arch-project#436) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-439-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d088934defaa749c48022c41eaad5fd61fc84ec3
# Push it to GitHub
git push --set-upstream origin backport/backport-439-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
PRs merged into feature branch feature/composite-monitors:
Added Alerting workflow model (#380)
Renamed chained monitor findings (#390)
Imports fixed (#394)
Added validation on IndexWorkflowRequest class (#405)
Extended deleted workflow response with list of monitor ids failed to delete (#416)