Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation on IndexWorkflowRequest class #405

Conversation

stevanbz
Copy link
Contributor

Description

Added validation when indexing the workflow

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
@stevanbz stevanbz requested a review from a team April 14, 2023 12:34
Copy link
Member

@lezzago lezzago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this?

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
@lezzago lezzago merged commit 5c740ae into opensearch-project:feature/composite-monitors Apr 17, 2023
eirsep pushed a commit to eirsep/common-utils that referenced this pull request May 24, 2023
* Added validation on IndexWorkflowRequest class

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Added unit test for index workflow request

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

---------

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants