Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds workflows model and workflow actions for Alerting Plugin #436

Merged
merged 5 commits into from
May 24, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented May 24, 2023

PRs merged into feature branch feature/composite-monitors:
Added Alerting workflow model (#380)
Renamed chained monitor findings (#390)
Imports fixed (#394)
Added validation on IndexWorkflowRequest class (#405)
Extended deleted workflow response with list of monitor ids failed to delete (#416)

stevanbz added 4 commits May 23, 2023 21:36
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
* Added validation on IndexWorkflowRequest class

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Added unit test for index workflow request

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

---------

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
@eirsep eirsep force-pushed the feature/2.8/workflows branch from 8a74256 to f003869 Compare May 24, 2023 04:36
getsaurabh02
getsaurabh02 previously approved these changes May 24, 2023
… delete (opensearch-project#416)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #436 (27e4300) into 2.x (db60532) will decrease coverage by 1.44%.
The diff coverage is 57.81%.

@@             Coverage Diff              @@
##                2.x     #436      +/-   ##
============================================
- Coverage     72.57%   71.14%   -1.44%     
- Complexity      709      771      +62     
============================================
  Files           113      125      +12     
  Lines          4700     5208     +508     
  Branches        605      661      +56     
============================================
+ Hits           3411     3705     +294     
- Misses         1037     1224     +187     
- Partials        252      279      +27     
Impacted Files Coverage Δ
...h/commons/alerting/action/DeleteWorkflowRequest.kt 0.00% <0.00%> (ø)
...arch/commons/alerting/action/GetWorkflowRequest.kt 0.00% <0.00%> (ø)
...rch/commons/alerting/action/GetWorkflowResponse.kt 0.00% <0.00%> (ø)
...org/opensearch/commons/alerting/util/IndexUtils.kt 53.33% <ø> (ø)
...h/commons/alerting/model/ChainedMonitorFindings.kt 16.00% <16.00%> (ø)
.../org/opensearch/commons/alerting/model/Delegate.kt 25.00% <25.00%> (ø)
.../commons/alerting/action/DeleteWorkflowResponse.kt 27.27% <27.27%> (ø)
...search/commons/alerting/AlertingPluginInterface.kt 38.80% <38.09%> (-0.33%) ⬇️
...opensearch/commons/alerting/model/WorkflowInput.kt 57.14% <57.14%> (ø)
...h/commons/alerting/action/IndexWorkflowResponse.kt 70.00% <70.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

@lezzago
Copy link
Member

lezzago commented May 24, 2023

Update PR description

@eirsep eirsep changed the title Adds workflows model and workflow actions Adds workflows model and workflow actions for Alerting Plugin May 24, 2023
@getsaurabh02 getsaurabh02 merged commit 2a6a6de into opensearch-project:2.x May 24, 2023
eirsep added a commit to eirsep/common-utils that referenced this pull request May 24, 2023
eirsep added a commit to eirsep/common-utils that referenced this pull request May 24, 2023
…arch-project#436)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep added a commit to eirsep/common-utils that referenced this pull request May 25, 2023
…arch-project#436)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep added a commit that referenced this pull request May 25, 2023
* Adds workflows model and workflow actions for Alerting Plugin (#436)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* adds tests for workflow request and response objects

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants