Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info page in catalog should show publisher #479

Closed
spadgett opened this issue Oct 10, 2017 · 8 comments · Fixed by openshift/origin-web-console#2243
Closed

Info page in catalog should show publisher #479

spadgett opened this issue Oct 10, 2017 · 8 comments · Fixed by openshift/origin-web-console#2243
Assignees
@rhamilto @spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

spadgett commented Oct 10, 2017 •
edited by rhamilto
Loading

Right now the publisher information is not shown when you click an item to provision it.
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Oct 10, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 10, 2017
@rhamilto
Copy link
Member

"Publisher information" === spec.externalMetadata.providerDisplayName?

screen shot 2017-10-10 at 12 05 16 pm

@spadgett
Copy link
Member Author

You should be able to use $ctrl.serviceClass.vendor in the dialog.

@rhamilto
Copy link
Member

@ncameronbritt, I'm assume we want to change the icons/images from horizontally centered to top aligned?

screen shot 2017-10-10 at 12 18 57 pm

screen shot 2017-10-10 at 12 19 26 pm

@ncameronbritt
Copy link

Yeah, I think so. What do you think @openshift/team-ux-review ?

@rhamilto
Copy link
Member

@openshift/team-ux-review, per http://openshift.github.io/openshift-origin-design/web-console/5-components/order-from-catalog#1---information-step, tags should also be muted?

screen shot 2017-10-10 at 12 29 13 pm

@spadgett
Copy link
Member Author

@jennyhaines ^

@rhamilto rhamilto mentioned this issue Oct 10, 2017
Merged
@jennyhaines
Copy link

jennyhaines commented Oct 10, 2017 •
edited
Loading

@spadgett @rhamilto @ncameronbritt - I think the top alignment of the logo is a nice change. Changing the tags to be muted is also a good idea. I think it helps set it apart from the publisher name. The muted color also helps with the hierarchy since the tags are in CAPS which sort of "scream" when at a darker color.

@beanh66
Copy link
Member

beanh66 commented Oct 11, 2017

Agreed @jennyhaines, top aligned icons and muted tags looks great.

@rhamilto rhamilto mentioned this issue Oct 11, 2017
Merged
openshift-merge-robot added a commit to openshift/origin-web-console that referenced this issue Oct 13, 2017
@openshift-merge-robot
Merge pull request #2243 from rhamilto/issue-479
3107f25 
Automatic merge from submit-queue.

Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it

Fixes openshift/origin-web-catalog#479
And fixes #2242

Requires openshift/origin-web-catalog#485

<img width="915" alt="screen shot 2017-10-10 at 2 32 50 pm" src="https://user-images.githubusercontent.com/895728/31404030-dde2fe2c-adc8-11e7-9a73-68bd4e1ed138.PNG">
<img width="925" alt="screen shot 2017-10-10 at 2 32 56 pm" src="https://user-images.githubusercontent.com/895728/31404031-ddf83dd2-adc8-11e7-8ec8-13aca55d70f3.PNG">
<img width="909" alt="screen shot 2017-10-10 at 2 33 06 pm" src="https://user-images.githubusercontent.com/895728/31404032-de091102-adc8-11e7-9253-9211cc3064f1.PNG">
<img width="926" alt="screen shot 2017-10-10 at 2 33 12 pm" src="https://user-images.githubusercontent.com/895728/31404035-de237bf0-adc8-11e7-9eb8-060ffc45435f.PNG">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
3.7.0
Development

Successfully merging a pull request may close this issue.

Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it
5 participants
@rhamilto @spadgett @ncameronbritt @beanh66 @jennyhaines