Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import YAML/JSON info page does not use SVG images #2242

Closed
rhamilto opened this issue Oct 10, 2017 · 1 comment · Fixed by #2243
Closed

Import YAML/JSON info page does not use SVG images #2242

rhamilto opened this issue Oct 10, 2017 · 1 comment · Fixed by #2243
Assignees
@rhamilto @spadgett
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3
Milestone
3.7.0

Comments

@rhamilto
Copy link
Member

Presumably we want to swap the font icon for the SVG when importing?

screen shot 2017-10-10 at 1 56 03 pm
@rhamilto rhamilto added area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Oct 10, 2017
@rhamilto rhamilto added this to the 3.7.0 milestone Oct 10, 2017
@spadgett
Copy link
Member

Yeah, missed this one :(

@rhamilto rhamilto mentioned this issue Oct 10, 2017
Merged
@spadgett spadgett mentioned this issue Oct 10, 2017
Closed
openshift-merge-robot added a commit that referenced this issue Oct 13, 2017
@openshift-merge-robot
Merge pull request #2243 from rhamilto/issue-479
3107f25 
Automatic merge from submit-queue.

Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it

Fixes openshift/origin-web-catalog#479
And fixes #2242

Requires openshift/origin-web-catalog#485

<img width="915" alt="screen shot 2017-10-10 at 2 32 50 pm" src="https://user-images.githubusercontent.com/895728/31404030-dde2fe2c-adc8-11e7-9a73-68bd4e1ed138.PNG">
<img width="925" alt="screen shot 2017-10-10 at 2 32 56 pm" src="https://user-images.githubusercontent.com/895728/31404031-ddf83dd2-adc8-11e7-8ec8-13aca55d70f3.PNG">
<img width="909" alt="screen shot 2017-10-10 at 2 33 06 pm" src="https://user-images.githubusercontent.com/895728/31404032-de091102-adc8-11e7-9253-9211cc3064f1.PNG">
<img width="926" alt="screen shot 2017-10-10 at 2 33 12 pm" src="https://user-images.githubusercontent.com/895728/31404035-de237bf0-adc8-11e7-9eb8-060ffc45435f.PNG">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
3.7.0
Development

Successfully merging a pull request may close this issue.

Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it
2 participants
@rhamilto @spadgett