Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it #2243

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it #2243

merged 1 commit into from
Oct 13, 2017

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 10, 2017 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2017
@spadgett spadgett mentioned this pull request Oct 10, 2017
Closed
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2017
@rhamilto rhamilto changed the title [WIP] Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it Adding vendor (publisher) to info screens, adds docUrl and supportUrl to info screens that lacked it Oct 13, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2017
@rhamilto
Copy link
Member Author

/lgtm

@openshift-ci-robot
Copy link

@rhamilto: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 3107f25 into openshift:master Oct 13, 2017
@rhamilto rhamilto deleted the issue-479 branch October 13, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import YAML/JSON info page does not use SVG images Info page in catalog should show publisher
5 participants
@rhamilto @openshift-ci-robot @spadgett @openshift-merge-robot @jeff-phillips-18