Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch image api to use SAR client, not registry #16148

Closed
wants to merge 1 commit into from
Closed

switch image api to use SAR client, not registry #16148

wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 5, 2017

Use a normal client for running SAR checks.

@mfojtik @soltysh this is on the path to splitting out the storage for the image APIs

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
deads2k
deads2k commented Sep 5, 2017
View reviewed changes
pkg/image/registry/imagestream/strategy.go
ResourceAttributes: &authorizationapi.ResourceAttributes{
Namespace: tagRef.From.Namespace,
Verb: "get",
Group: imageapi.GroupName,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change this. Looks like a typo before. This groupified check should also have permission.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does empty group vs. image.openshift.io matters here? guess we need support both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does empty group vs. image.openshift.io matters here? guess we need support both

It's a server back to itself call, the roles will be reconciled. I think this usage is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for clarification :)

@mfojtik
Copy link
Contributor

mfojtik commented Sep 5, 2017

/approve no-issue

@mfojtik
Copy link
Contributor

mfojtik commented Sep 5, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2017
@0xmichalis
Copy link
Contributor

/lgtm cancel

This PR has been breaking our batch jobs since yesterday because in conjuction with #16147, it produces a compilation error.

/test all

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2017
@deads2k deads2k mentioned this pull request Sep 6, 2017
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Sep 6, 2017

combined in https://github.com/openshift/origin/pull/16170/commits

@deads2k deads2k closed this Sep 6, 2017
openshift-merge-robot added a commit that referenced this pull request Sep 6, 2017
@openshift-merge-robot
Merge pull request #16170 from deads2k/storage-01-separate
852bb01 
Automatic merge from submit-queue (batch tested with PRs 16110, 16170, 16140, 16173)

Separating storage

combination of

1. #16159
2. #16158
3. #16156
4. #16152
5. #16148

 to save our queue.  All already  lgtm'ed
@deads2k deads2k deleted the image-01-dead branch January 24, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik mfojtik left review comments

Assignees

@mfojtik mfojtik

@smarterclayton smarterclayton

@legionus legionus

@0xmichalis 0xmichalis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@deads2k @mfojtik @0xmichalis @openshift-merge-robot @smarterclayton @legionus @openshift-ci-robot