Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move oauth storage to server #16158

Closed
wants to merge 1 commit into from
Closed

move oauth storage to server #16158

wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 5, 2017

Moves the oauth storage into its own API server. What do you know, we do have one that doesn't suck to move.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Sep 5, 2017

@openshift/sig-security since its your storage. This doesn't ripple externally, but I do plan to start turning the screws on dependencies between groups.

@mfojtik
Copy link
Contributor

mfojtik commented Sep 6, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k mentioned this pull request Sep 6, 2017
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Sep 6, 2017

https://github.com/openshift/origin/pull/16170/commits

@deads2k deads2k closed this Sep 6, 2017
openshift-merge-robot added a commit that referenced this pull request Sep 6, 2017
@openshift-merge-robot
Merge pull request #16170 from deads2k/storage-01-separate
852bb01 
Automatic merge from submit-queue (batch tested with PRs 16110, 16170, 16140, 16173)

Separating storage

combination of

1. #16159
2. #16158
3. #16156
4. #16152
5. #16148

 to save our queue.  All already  lgtm'ed
@deads2k deads2k deleted the oauth-04-storage branch January 24, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @mfojtik @openshift-merge-robot @soltysh @openshift-ci-robot