Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move images to their own apiserver #16152

Closed
wants to merge 3 commits into from
Closed

move images to their own apiserver #16152

wants to merge 3 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 5, 2017

Builds on two other pulls, only the last commit is unique and not lgtm'ed

@bparees fyi

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 5, 2017
mfojtik
mfojtik reviewed Sep 5, 2017
View reviewed changes
pkg/image/apiserver/apiserver.go
return nil, fmt.Errorf("error building REST storage: %v", err)
}
imageRegistry := image.NewRegistry(imageStorage)
imageSignatureStorage := imagesignature.NewREST(deprecatedOpenshiftClientForImages.Images())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh we need to get rid of this

@deads2k can you make a TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k can you make a TODO?

There are a few of these bouncing around in our separated servers. I think we'll hunt them down based on package imports rather than todos.

These are bugs after all, so they go in after freeze. We're using the wrong API and need to switch to groupified.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently working on having them removed from entire pkg/image.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Sep 6, 2017

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Sep 6, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k mentioned this pull request Sep 6, 2017
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Sep 6, 2017

https://github.com/openshift/origin/pull/16170/commits

@deads2k deads2k closed this Sep 6, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 6, 2017 •
edited

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 5188863 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot added a commit that referenced this pull request Sep 6, 2017
@openshift-merge-robot
Merge pull request #16170 from deads2k/storage-01-separate
852bb01 
Automatic merge from submit-queue (batch tested with PRs 16110, 16170, 16140, 16173)

Separating storage

combination of

1. #16159
2. #16158
3. #16156
4. #16152
5. #16148

 to save our queue.  All already  lgtm'ed
@deads2k deads2k deleted the image-03-storage branch January 24, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik mfojtik left review comments

@soltysh soltysh soltysh left review comments

Assignees

@mfojtik mfojtik

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @mfojtik @openshift-merge-robot @openshift-ci-robot @soltysh