Bug 1857522: 7-21-2020 merge #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit asks our tests to poll for the presence of annotations on the pods that are created as some signal that the network is, almost, ready. The OVN/HO master are responsible for writing these annotations. The nodes wait on the presence of theses anootations before processing can continue. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Adds log rotation support for ovn-k8s-cni-overlay.log file. Making (MaxBackups, MaxAge, MaxSize) as a configurable values through yaml files. Signed-off-by: Pardhakeswar Pacha <ppacha@nvidia.com>
The delete conntrack needs additional capibilities recently merged into github.com/vishvananda/netlink Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
during the code review of edb24e6 (topology changes to enable Node-Local Services Access in Shared GW Mode) it was decided to use the prefix of rtos- and stor- for the ports connecting node_local_switch and the ovn_cluster_router. however, for the switch port we are still using a different convention. Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
there were certain test cases in master_test.go that weren't enabled for shared gateway mode, but we were adding fake commands related to building shared gateway logical topology by explicitly overwriting config.Gateway.Mode to config.GatewayModeShared. this causes confusion and this commit removes that code. Note: we already have tests to cover those set of commands. Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
the original implementation of the conntrack deletion will cause errors it deletes all conntrack accross all ports for all protocols. after revendoring the netlink code use it to allow filtering the UDP and SCTP protocols and filter to delete selected ports Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
since the focus in the community is on OVN DB standalone and OVN DB RAFT HA, the corosync/pacemaker got left behind and is not maintained, so it is better to remove the support for it from the repo. Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
This commit adds a github action that is triggered every 15 minutes. It identifies stale test runs by cross-referencing the Git SHA of the commit under test with the latest SHA on the pull request. If the two do not match, then the job is cancelled. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Vishwanath Jayaraman <vjayaram@redhat.com>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
.github: Add Action To Cleanup Stale Test Runs
not all hybrid network cases will have externalGateway and VTEP IPs. Correct the functionality of CopyNamespaceAnnotationToPod() to only copy annotations types.HybridOverlayExternalGw and types.HybridOverlayVTEP to a pod if they exist on the namespace. Then the AddPod() can correctly deal with unset values. without this patch the test 'sets up local pod flows' in go-controller/hybrid-overlay/pkg/controller/node_linux_test. shows errors. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
when adding a pod for a windows linux hybrid network linux nodes will not have annotation values types.HybridOverlayExternalGw and types.HybridOverlayVTEP. Adding a test to see that the correct behavior will happen when those annotaions do not exist Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
Signed-off-by: Shahar Klein <sklein@nvidia.com>
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
…cts for Services Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
…cer" naming in logs Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
…nagement of getLoadBalancer in service.go Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
The coverage/show command against ovn-northd provides metrics that captures various aspects of ovn-northd's functionality. This commit is going to capture those values and export it. In addition to those metrics, the output of "status" command is exported as well. Please see below document for more information: https://docs.google.com/document/d/\ 1BAsjLOpAeSyIq2UcyukPK7PgKCqgAKuHcz3962DtoUo/edit?usp=sharing Co-authored-by: Pardhakeswar Pacha <ppacha@nvidia.com> Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Was missing a `run: |` for the build step Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
The coverage/show command against ovn-controller provides metrics that captures various aspects of ovn-controller's functionality. This commit is going to capture those values and export it. In addition to those metrics, the following metrics on each of the ovn chassis is exported: -- ovn-openflow-probe-interval -- ovn-remote-probe-interval -- ovn-monitor-all -- ovn-encap-ip -- ovn-encap-type -- ovn-remote -- integration_bridge_openflow_total -- integration_bridge_patch_ports_total -- integration_bridge_geneve_ports_total Please see below document for more information: https://docs.google.com/document/d/\ 1BAsjLOpAeSyIq2UcyukPK7PgKCqgAKuHcz3962DtoUo/edit?usp=sharing Co-authored-by: Pardhakeswar Pacha <ppacha@nvidia.com> Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Conntrack update
Correct the way that externalGateway and VTEP IP are copied
test: Check network readiness before connection tests
Create Junit Reports for all test suites that support it
Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
One major change brought in by the vendor update is the variables for Get(), List(), Update(), Delete(), and Create(); update the calls to accommodate the vendor update. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
trozet
force-pushed
the
7-17-2020-merge
branch
6 times, most recently
from
292e2e9
to
6d7b2f3
Compare
ovn-20.06.1-0.fc31 and ovn-20.06.1-4.fc31 are failing CI. So force OVN to run ovn-20.03.0-3.fc31 while root cause is determined. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Downgrade OVN to ovn-20.03.0-3.fc31
Addresses must be a space-separated string sent as a single value. The slice passed to LSPSetAddress() turns into an OvsSet in which has special semantics for the second and later elements and causes OVSDB to insert a newline between the MAC and IPs, leading to northd complaints that the address is malformed. Signed-off-by: Dan Williams <dcbw@redhat.com>
ovn: fix setting addresses on logical switch ports
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, dcbw, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This was merged with e2e-metal-ipi tests still running, which I think failed due to the changes here. It'd be great if you'd check out the results on e2e-metal-ipi when merging changes, since none of the other OVN tests cover IPv6, right? I filed https://bugzilla.redhat.com/show_bug.cgi?id=1860710 |
|
@stbenjam the merge happens automatically. You could propose making it required to pass for merge to happen. I didn't know metal-ipi used ipv6 (maybe we could add that to the job name?), but it would be nice to have that as a required job as long as it is stable. |
|
Well it’s a bit of a catch 22, how can we be stable when we’re constantly broken by changes? I don’t know how to break that cycle. I think the only thing we can ask is that you look at optional jobs before approving/lgtm to make sure if it’s failing it wasn’t due to the changes here. |
|
I'll check when I can. Some good news is upstream we are about to add ipv6
jobs, which should help us to avoid breaking you downstream in the future.
…On Sun, Jul 26, 2020, 5:30 PM Stephen Benjamin ***@***.***> wrote:
Well it’s a bit of a catch 22, how can we be stable when we’re constantly
broken by changes? I don’t know how to break that cycle.
I think the only thing we can ask is that you look at optional jobs before
approving/lgtm to make sure if it’s failing it wasn’t due to the changes
here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQPKLPN6CSZLUDYK7K7PL3R5SN5PANCNFSM4O6JI3GQ>
.
|
|
Do you think we could take #215 downstream before that happens? |
|
No the fix needs to be upstream first and it's already part of:
ovn-org/ovn-kubernetes#1343
I expect that to be merged today or tomorrow and then we will do another
upstream -> downstream merge.
…On Sun, Jul 26, 2020, 5:50 PM Stephen Benjamin ***@***.***> wrote:
Do you think we could take #215
<#215> downstream before
that happens?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQPKLKFSHLTQ7LWWP6KESDR5SQKJANCNFSM4O6JI3GQ>
.
|
|
Right, that PR was open since May so I didn't know when it would land. If it's in the next day that's fine but this is the last week before feature freeze. ovn-org/ovn-kubernetes#1539 was the upstream version of the OpenShift PR if 1343 is going to be delayed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.