-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 only KIND deployment to CI matrix. #1343
Conversation
fac7d53
to
3dd2799
Compare
39bee80
to
1168eaf
Compare
6c8dc84
to
427c74d
Compare
You can't use an ipv6 address for the external API, docker does not support ipv6 port mapping Status: Downloaded newer image for kindest/haproxy:2.1.1-alpine |
Use always the ipv4 host address for the apiserver field, this will keep compatibility and people will be able to connect with kubectl from outside |
🤞 |
great 🎉 |
@trozet PTAL |
contrib/kind.sh
Outdated
@@ -313,6 +295,10 @@ docker build -t ovn-daemonset-f:dev -f Dockerfile.fedora . | |||
# and since OVN has to provide the connectivity to service | |||
# it can not be bootstrapped | |||
|
|||
# This is the address of the node with the control-plane | |||
# If HA, multiple control-plane nodes, KIND deploys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this Yoda speak? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me @Billy99, just squash it with the first commit and then I think we are good to go
Per suggestions from @aojea, improve how KIND is used. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Update scripts to support IPv6 only. Resolves: ovn-org#977 Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Per comment in ovn-org#1401, limit the test cases. This does not fix the root cause of the issue, but addresses a comment in the issue: ovn-org#1401 (comment) Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
4bd505b
to
fe26900
Compare
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Signed-off-by: Billy McFall 22157057+Billy99@users.noreply.github.com
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog