vendor: update libovsdb #1539
Closed
vendor: update libovsdb #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of libovsdb has a parsing error when handling IPv6 addresses, that was fixed in eBay/libovsdb#20. Error I'm getting from ovn-kubernetes: ``` ovnkube.go:130] error when trying to initialize go-ovn NB client: couldn't initialize NBDB client: error creating SSL OVNDBClient for database OVN_Northbound at address ssl:[fd2e:6f44:5dd8:c956::14]:9641, ssl:[fd2e:6f44:5dd8:c956::15]:9641,ssl:[fd2e:6f44:5dd8:c956::16]:9641: failed to connect: dial tcp: address [fd2e:6f44: missing ']' in address\n ``` Commands run: - go get -u github.com/ebay/libovsdb@3332afaeb27c0df7184e92c921e9bf19a4d19a93 - go mod vendor - go mod tidy Signed-off-by: Stephen Benjamin <stephen@redhat.com>
stbenjam
force-pushed
the
update-libovsdb
branch
from
e820726
to
2a7d081
Compare
|
#1343 already pulls in the patch, but wasn't sure how long it'd be until that lands |
|
FYI - PR #1343 should merge soon and has this in one of the commits associated with the PR. |
Yup, I saw, thanks! I just wasn't sure how far away it was from merging. I got bitten by this in OpenShift since ovn got rebased and pulled in the libovsdb bug and broke my platform. |
|
#1343 merged, thanks!! |
jcaamano
pushed a commit
to jcaamano/ovn-kubernetes
that referenced
this pull request
Mar 9, 2023
Dockerfiles: switch to dnf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
The current version of libovsdb has a parsing error when handling IPv6
addresses, that was fixed in eBay/libovsdb#20.
Error I'm getting from ovn-kubernetes:
Commands run:
- Special notes for reviewers
- How to verify it
Use IPv6.
- Description for the changelog
Revendored libovsdb to fix a parsing error with IPv6 addresses.