Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update finalzier to CRD doc #287

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Jun 19, 2024

Depends-On: openstack-k8s-operators/lib-common#519
Depends-On: openstack-k8s-operators/mariadb-operator#231

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi stuggi requested a review from fmount June 19, 2024 06:00
@openshift-ci openshift-ci bot requested review from dprince and viroel June 19, 2024 06:00
@stuggi stuggi requested review from olliewalsh and abays and removed request for dprince and viroel June 19, 2024 06:00
Copy link
Collaborator

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor Author

stuggi commented Jun 19, 2024

/test manila-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Jun 19, 2024

/test manila-operator-build-deploy-tempest

1 similar comment
@stuggi
Copy link
Contributor Author

stuggi commented Jun 19, 2024

/test manila-operator-build-deploy-tempest

@openshift-merge-bot openshift-merge-bot bot merged commit cd7db8b into openstack-k8s-operators:main Jun 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants