Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update finalzier to CRD doc #215

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Jun 18, 2024

Copy link
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lokk ok for me but we need to wait for openstack-k8s-operators/mariadb-operator#231

@stuggi
Copy link
Contributor Author

stuggi commented Jun 18, 2024

lokk ok for me but we need to wait for openstack-k8s-operators/mariadb-operator#231

right, will do the rest of the PRs tomorrow, as they all/most of them have the dep.

Copy link
Collaborator

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stuggi. Looks good. We can land it as soon as the deps lands.

Depends-On: openstack-k8s-operators/lib-common#519
Depends-On: openstack-k8s-operators/mariadb-operator#231

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stuggi
Copy link
Contributor Author

stuggi commented Jun 19, 2024

/test placement-operator-build-deploy-kuttl

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, mrkisaolamb, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abays,mrkisaolamb,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c17fa31 into openstack-k8s-operators:main Jun 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants