update finalzier to CRD doc #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends-on: openstack-k8s-operators/lib-common#519 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
requested review from
olliewalsh,
abays,
zzzeek and
dciabrin
and removed request for
lewisdenny and
viroel
zzzeek
approved these changes
Jun 18, 2024
| @@ -458,13 +458,12 @@ func (d *Database) DeleteFinalizer( | |||
| h *helper.Helper, | |||
| ) error { | |||
|
|
|||
| secretFinalizer := fmt.Sprintf("mariadb.openstack.org/%s", h.GetFinalizer()) | |||
There was a problem hiding this comment.
Just to confirm, what I'm seeing in https://github.com/openstack-k8s-operators/lib-common/pull/519/files combined with this change indicates that the name of the finalizer will change from:
mariadb.openstack.org/<kind>
to
openstack.org/<kind>
and I assume that's what we want to have for all operators.
There was a problem hiding this comment.
yes, correct, want to align them to openstack.org/<kind> . we also need to consider the max length of 63char. so omit a prefix per operator can be omitted I think
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 098a347
into
openstack-k8s-operators:main
6 checks passed
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/barbican-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/cinder-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/designate-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/heat-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/ironic-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/manila-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/octavia-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/telemetry-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/nova-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/heat-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/placement-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/telemetry-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync finalizers across the operators
Depends-on: openstack-k8s-operators/lib-common#519