Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track usability problems when RPC are split across span IDs #1480

Open
4 of 5 tasks
codefromthecrypt opened this issue Jan 10, 2017 · 5 comments
Open
4 of 5 tasks

Track usability problems when RPC are split across span IDs #1480

codefromthecrypt opened this issue Jan 10, 2017 · 5 comments
Labels
enhancement ui Zipkin UI

Comments

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Jan 10, 2017 •
edited by jorgheymans
Loading

Some are intentionally or accidentally splitting RPCs across different span IDs. For example, they might intentionally fork a span ID when receiving B3 headers. This could also happen when an intermediary forks a new span, but fails to report it to Zipkin. In either case, the client ends up as a parent span as opposed to the same span as the server.

The goal of this issue is to support the case where a client span is a parent of the server span in the existing model. This is a precondition of any work that assumes single-host (like #939), or at least a warning of what glitches will occur until single-host RPC spans are supported.

Here are the main feature areas to explore:

  • UI Usability (how to make split span events appear in the same detail panel) zipkin-ui does not support non-shared spans #1799
  • Clock skew correction (correct skew when "cs" "cr" is the parent of "sr" "ss")
  • Dependency linking (ensure split spans increment service link only once) Supports dependency linking on single-host RPC spans #1656
  • B3 propagation (ensure single-host process is captured so it can be used consistently)
  • Document how to handle grey-box intermediaries (proxies that once added annotations between client and server ones in the same span)

transparent proxies should be unimpacted as they just sent headers across without changing them or reporting anything to zipkin anyway.
@codefromthecrypt
Copy link
Member Author

cc @openzipkin/instrumentation-owners @fedj @openzipkin/core @cburroughs @rogeralsing

@fedj fedj mentioned this issue Jan 16, 2017
Open
@codefromthecrypt
Copy link
Member Author

cc @reta

@codefromthecrypt codefromthecrypt mentioned this issue Mar 10, 2017
Closed
@codefromthecrypt codefromthecrypt mentioned this issue Apr 9, 2017
Merged
@bogdandrutu bogdandrutu mentioned this issue Apr 12, 2017
Closed
@codefromthecrypt
Copy link
Member Author

one can model single producer multiple consumer messages with a parent-child relationship similar to single-host spans in RPC. For example, by using X-B3-SpanId as the parent id of the consumer span, many consumers will end up as different spans. So, this pattern for single-host spans also applies to SPMC

https://github.com/openzipkin/b3-propagation#why-is-parentspanid-propagated

codefromthecrypt pushed a commit that referenced this issue Jul 20, 2017
Supports dependency linking on single-host RPC spans
073e875 
Before, if a client span was a parent of a server span, linking wouldn't
work.

See #1480
@codefromthecrypt codefromthecrypt mentioned this issue Jul 20, 2017
Merged
@codefromthecrypt
Copy link
Member Author

added #1656 to fix dependency linking. Noticed this when implementing the simple json thing

codefromthecrypt pushed a commit to openzipkin/brave that referenced this issue Oct 6, 2017
Adds Tracing.Builder.supportsJoin to disable span ID sharing
44330c7 
Similar to ClientServerSameSpan in zipkin-go, this adds the ability to
opt out of span sharing between the client and server side of an RPC.
This is important when reporting to systems that do not share span IDs,
such as Google Stackdriver and Amazon X-Ray.

Note: this still defaults to true, in favor of existing Zipkin
implementations. See openzipkin/zipkin#1480
codefromthecrypt pushed a commit to openzipkin/brave that referenced this issue Oct 6, 2017
Adds Tracing.Builder.supportsJoin to disable span ID sharing
35f5d5f 
Similar to ClientServerSameSpan in zipkin-go, this adds the ability to
opt out of span sharing between the client and server side of an RPC.
This is important when reporting to systems that do not share span IDs,
such as Google Stackdriver and Amazon X-Ray.

Note: this still defaults to true, in favor of existing Zipkin
implementations. See openzipkin/zipkin#1480
@codefromthecrypt codefromthecrypt mentioned this issue Oct 6, 2017
Merged
codefromthecrypt pushed a commit to spring-cloud/spring-cloud-sleuth that referenced this issue Oct 6, 2017
Adds spring.sleuth.supports-join to disable span ID sharing
5bb24af 
This adds the ability to opt out of span sharing between the client and
server side of an RPC. This is important when reporting to systems that
do not share span IDs, such as Google Stackdriver and Amazon X-Ray.

Note: this still defaults to true, in favor of existing Zipkin
implementations. See openzipkin/zipkin#1480

See #395
See #459
@codefromthecrypt codefromthecrypt mentioned this issue Oct 6, 2017
Merged
codefromthecrypt pushed a commit to openzipkin/brave that referenced this issue Oct 6, 2017
@adriancole
Adds Tracing.Builder.supportsJoin to disable span ID sharing (#513)
0be5039 
Similar to ClientServerSameSpan in zipkin-go, this adds the ability to
opt out of span sharing between the client and server side of an RPC.
This is important when reporting to systems that do not share span IDs,
such as Google Stackdriver and Amazon X-Ray.

Note: this still defaults to true, in favor of existing Zipkin
implementations. See openzipkin/zipkin#1480
@mpetazzoni mpetazzoni mentioned this issue Dec 12, 2017
Closed
@codefromthecrypt codefromthecrypt mentioned this issue Dec 12, 2017
Closed
codefromthecrypt pushed a commit that referenced this issue Nov 8, 2018
Corrects clock-skew on single host spans
2504cee 
See #1480
@codefromthecrypt codefromthecrypt mentioned this issue Nov 8, 2018
Merged
codefromthecrypt pushed a commit that referenced this issue Nov 9, 2018
@adriancole
Corrects clock-skew on single host spans
8ca73cc 
See #1480
@codefromthecrypt
Copy link
Member Author

please take a look at #2302 and let me know if this is still desirable! I think this is the last step cc @ivantopo

abesto pushed a commit to abesto/zipkin that referenced this issue Sep 10, 2019
@abesto
Corrects clock-skew on single host spans
d18d71f 
See openzipkin#1480
thgoexpt added a commit to thgoexpt/Java-distributed-tracing-implementation that referenced this issue Apr 7, 2022
@thgoexpt
Adds Tracing.Builder.supportsJoin to disable span ID sharing (#513)
7a1d816 
Similar to ClientServerSameSpan in zipkin-go, this adds the ability to
opt out of span sharing between the client and server side of an RPC.
This is important when reporting to systems that do not share span IDs,
such as Google Stackdriver and Amazon X-Ray.

Note: this still defaults to true, in favor of existing Zipkin
implementations. See openzipkin/zipkin#1480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ui Zipkin UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt