Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin-ui does not support non-shared spans #1799

Closed
devinsba opened this issue Nov 15, 2017 · 6 comments
Closed

zipkin-ui does not support non-shared spans #1799

devinsba opened this issue Nov 15, 2017 · 6 comments
Labels

Comments

@devinsba
Copy link
Member

Feature Request

With the advent of the X-Ray compatible modes for zipkin/brave comes the fact that X-Ray spans (segments) are not shared by client and server so the UI ends up losing the hierarchy information. It still orders correctly because of timestamps. I would be great to support this model of spans in the native zipkin UI

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Nov 16, 2017 via email

@codefromthecrypt
Copy link
Member

possibly a dupe of #963?

@codefromthecrypt
Copy link
Member

In the current api, I think maybe cheapest win is fusing single-host spans together. Basically move the server span into its client and adjust ids. However, I think possibly there's something more to ask you about.

You suggest the hierarchy is wrong.. which is a different problem then seeing things in the same detail screen. Can you give an example of this? It would seem a broken hierarchy would also be a problem in X-Ray..

@codefromthecrypt
Copy link
Member

please take a look at #2302 and let me know if this is still desirable!

@codefromthecrypt
Copy link
Member

the logic has been completely written and so has the UI, so it might be easier to notice any new problem vs think through what's changed

@codefromthecrypt
Copy link
Member

one note relevant here is that lens allows multiple spans to be expanded which compensates somewhat for usability concerns on client and server spans that don't share an ID. I'm not sure it is worse than other tools like jaeger or stackdriver in this regard or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants