Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we handle single-host RPC spans in the UI? #963

Closed
codefromthecrypt opened this issue Feb 11, 2016 · 3 comments
Closed

How should we handle single-host RPC spans in the UI? #963

codefromthecrypt opened this issue Feb 11, 2016 · 3 comments
Labels

Comments

@codefromthecrypt
Copy link
Member

At least htrace, opentracing, google cloud trace and sleuth use single-host spans. For example, client send and server receive are in different spans, based on the client or the server tracer.

Zipkin's v1 model was designed to have client and server in the same span, hence the need for the annotations "cs" "sr" "ss" "sr". Zipkin v2 will probably move to single-host (per #939)

Zipkin's UI was designed for when a single span contained both client and server sides. Ex. there's a single bar for a client+server span, and there are dots for each of the major client or server events (such as client receive or server send). This cuts the visual depth of a trace quite a bit.

Conversely, single-host spans have a separate span for a client or a server. This means that a server span is visually below its client counterpart. For the same amount of RPCs, this is double the "bars" vs client+server spans.

Do we need any UI work wrt single-tracer RPC spans, or is status quo ok?

@codefromthecrypt
Copy link
Member Author

cc'ing some who might have an opinion: @marcingrzejszczak @yurishkuro @clehene

@codefromthecrypt codefromthecrypt changed the title How should we handle single-tracer RPC spans in the UI? How should we handle single-host RPC spans in the UI? Feb 12, 2016
@yurishkuro
Copy link
Contributor

@adriancole the examples you asked for. Looks fairly normal, the one weird thing is the query service adds server annotations to the middle span client.post. Also, the server span is centered, even though the IP is the same (though I haven't used the latest code).

3b47c02255029f91.json.txt

screen shot 2016-02-11 at 9 00 38 pm

screen shot 2016-02-11 at 9 01 45 pm

screen shot 2016-02-11 at 9 01 55 pm

screen shot 2016-02-11 at 9 02 06 pm

@codefromthecrypt
Copy link
Member Author

closed in favor of #1799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants